Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1969413003: Support Simple Cache in disk_cache_perftest. (Closed)

Created:
4 years, 7 months ago by gavinp
Modified:
4 years, 7 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support Simple Cache in disk_cache_perftest. I need to validate improvements to Simple Cache for Mac/Windows, this perftest is a great start. First, let's make the existing behaviour work for both cache backends. R=juliatuttle@chromium.org BUG=611464 Committed: https://crrev.com/c28fe1128c07709a72f0f06e52ef31612b2f2ab3 Cr-Commit-Position: refs/heads/master@{#393572}

Patch Set 1 #

Patch Set 2 : added braces #

Patch Set 3 : rename Hash test to BlockfileHash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -307 lines) Patch
M net/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D net/disk_cache/blockfile/disk_cache_perftest.cc View 1 chunk +0 lines, -260 lines 0 comments Download
A + net/disk_cache/disk_cache_perftest.cc View 1 2 11 chunks +55 lines, -45 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
gavinp
Julia: PTAL. Do these build in any of the tries? I'm a bit anxious about ...
4 years, 7 months ago (2016-05-12 17:46:13 UTC) #1
Julia Tuttle
lgtm, and looks like it looks good to the trybots too (at least patch set ...
4 years, 7 months ago (2016-05-13 16:25:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969413003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969413003/40001
4 years, 7 months ago (2016-05-13 16:50:46 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 17:49:17 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 17:51:31 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c28fe1128c07709a72f0f06e52ef31612b2f2ab3
Cr-Commit-Position: refs/heads/master@{#393572}

Powered by Google App Engine
This is Rietveld 408576698