Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 19765010: postMessage() should throw a DataCloneError on invalid transferables (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use, lgombos
Visibility:
Public.

Description

postMessage() should throw a DataCloneError on invalid transferables As per the latest specification, postMessage() should throw a DataCloneError on invalid transferables: - http://www.whatwg.org/specs/web-apps/current-work/multipage/web-messaging.html#posting-messages - http://www.whatwg.org/specs/web-apps/current-work/multipage/web-messaging.html#dom-messageport-postmessage IE10 and Firefox behave according to specification but Blink was throwing an InvalidStateError instead. Also stop using extractTransferables() for the MessageEvent constructor and rely on toRefPtrNativeArray() instead. extractTransferables() does more than the MessageEvent constructor really needs and it is meant to be used to extract transferables from postMessageArgument. BUG=262887 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -110 lines) Patch
M LayoutTests/fast/events/constructors/message-event-constructor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/message-port-clone.html View 4 chunks +30 lines, -67 lines 0 comments Download
M LayoutTests/fast/events/message-port-clone-expected.txt View 1 chunk +18 lines, -9 lines 0 comments Download
M LayoutTests/fast/events/message-port-multi-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/resources/message-port-multi.js View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/fast/workers/worker-context-multi-port-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/workers/worker-multi-port-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/bindings/v8/V8Utilities.cpp View 3 chunks +12 lines, -10 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-22 14:42:07 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 5 months ago (2013-07-22 16:26:29 UTC) #2
haraken
LGTM2
7 years, 5 months ago (2013-07-23 00:25:26 UTC) #3
tkent
lgtm
7 years, 5 months ago (2013-07-23 01:59:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19765010/1
7 years, 5 months ago (2013-07-23 06:01:14 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 08:12:04 UTC) #6
Message was sent while issue was closed.
Change committed as 154738

Powered by Google App Engine
This is Rietveld 408576698