postMessage() should throw a DataCloneError on invalid transferables

Source/bindings/v8/V8Utilities.cpp

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 69 matching lines @@
             return false;
     }
 
     v8::Local<v8::Object> transferrables = v8::Local<v8::Object>::Cast(value);
 
     // Validate the passed array of transferrables.
     for (unsigned int i = 0; i < length; ++i) {
         v8::Local<v8::Value> transferrable = transferrables->Get(i);
         // Validation of non-null objects, per HTML5 spec 10.3.3.
         if (isUndefinedOrNull(transferrable)) {
-            setDOMException(InvalidStateError, isolate);
+            setDOMException(DataCloneError, isolate);
             return false;
         }
         // Validation of Objects implementing an interface, per WebIDL spec 4.1.15.
         if (V8MessagePort::HasInstance(transferrable, isolate, worldType(isolate))) {
             RefPtr<MessagePort> port = V8MessagePort::toNative(v8::Handle<v8::Object>::Cast(transferrable));
             // Check for duplicate MessagePorts.
             if (ports.contains(port)) {
-                setDOMException(InvalidStateError, isolate);
+                setDOMException(DataCloneError, isolate);
                 return false;
             }
             ports.append(port.release());
         } else if (V8ArrayBuffer::HasInstance(transferrable, isolate, worldType(isolate)))
             arrayBuffers.append(V8ArrayBuffer::toNative(v8::Handle<v8::Object>::Cast(transferrable)));
         else {
-            throwTypeError(isolate);
+            setDOMException(DataCloneError, isolate);
             return false;
         }
     }
     return true;
 }
 
 bool getMessagePortArray(v8::Local<v8::Value> value, MessagePortArray& ports, v8::Isolate* isolate)
 {
-    ArrayBufferArray arrayBuffers;
-    bool result = extractTransferables(value, ports, arrayBuffers, isolate);
-    if (!result)
-        return false;
-    if (arrayBuffers.size() > 0) {
-        throwTypeError("MessagePortArray argument must contain only MessagePorts", isolate);
+    if (isUndefinedOrNull(value)) {
+        ports.resize(0);
+        return true;
+    }
+    if (!value->IsArray()) {
+        throwTypeError(isolate);
         return false;
     }
-    return true;
+    bool success = false;
+    ports = toRefPtrNativeArray<MessagePort, V8MessagePort>(value, isolate, &success);
+    return success;
 }
 
 void removeHiddenDependency(v8::Handle<v8::Object> object, v8::Local<v8::Value> value, int cacheIndex, v8::Isolate* isolate)
 {
     v8::Local<v8::Value> cache = object->GetInternalField(cacheIndex);
     if (!cache->IsArray())
         return;
     v8::Local<v8::Array> cacheArray = v8::Local<v8::Array>::Cast(cache);
     for (int i = cacheArray->Length() - 1; i >= 0; --i) {
         v8::Local<v8::Value> cached = cacheArray->Get(v8::Integer::New(i, isolate));
@@ skipping 20 matching lines @@
 
 ScriptExecutionContext* getScriptExecutionContext()
 {
     if (WorkerScriptController* controller = WorkerScriptController::controllerForContext())
         return controller->workerGlobalScope();
 
     return currentDocument();
 }
 
 } // namespace WebCore