Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1976453003: Add headers-only component to DiskCachePerfTest. (Closed)

Created:
4 years, 7 months ago by gavinp
Modified:
4 years, 7 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@open-speeder-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add headers-only component to DiskCachePerfTest. Reading only the headers is a significant gap between SimpleCache and the blockfile backend. Let's test that independently of reading the whole bodies. R=juliatuttle@chromium.org BUG=611464 Committed: https://crrev.com/dfe07b41c2a19e02c9d8e5e5101c12babe4ca5fe Cr-Commit-Position: refs/heads/master@{#393595}

Patch Set 1 #

Patch Set 2 : a bit cleaner #

Patch Set 3 : coding style fix #

Patch Set 4 : cleaner, remove bad member variable #

Patch Set 5 : block fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -74 lines) Patch
M net/disk_cache/disk_cache_perftest.cc View 1 2 3 4 10 chunks +83 lines, -74 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
gavinp
Julia: PTAL. Dunno why the tries are all failing? Don't deal with dependant changes well?
4 years, 7 months ago (2016-05-12 20:31:21 UTC) #1
gavinp
Note: this is downstream of the two other changes I sent out to you this ...
4 years, 7 months ago (2016-05-12 20:38:00 UTC) #2
Julia Tuttle
lgtm.
4 years, 7 months ago (2016-05-13 16:32:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976453003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976453003/80001
4 years, 7 months ago (2016-05-13 18:02:05 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-13 19:03:42 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 19:04:41 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/dfe07b41c2a19e02c9d8e5e5101c12babe4ca5fe
Cr-Commit-Position: refs/heads/master@{#393595}

Powered by Google App Engine
This is Rietveld 408576698