Add permission parsing and the removeService API.

Add permission parsing and the removeService API.

This CL adds and fixes permission and property parsing for local GATT
characteristics and descriptors. It also implements and adds a test for
the removeService API.

R=xiyuan@chromium.org
BUG=611236
Committed: https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448
Cr-Commit-Position: refs/heads/master@{#393391}

[xiyuan, 2016-05-12 19:25:37]

lgtm

https://codereview.chromium.org/1976453002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
(right):

https://codereview.chromium.org/1976453002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:186:
if (find(api_permissions.begin(), api_permissions.end(), permission) !=
nit: just a return ?

  return find(api_permissions.begin(), api_permissions.end(), permission) !=
api_permissions.end();

https://codereview.chromium.org/1976453002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:209:
properties |=
nit: wrap with {} if condition and branch takes more than one line, here and
other places.

[rkc, 2016-05-12 20:32:54]

https://codereview.chromium.org/1976453002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
(right):

https://codereview.chromium.org/1976453002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:186:
if (find(api_permissions.begin(), api_permissions.end(), permission) !=
On 2016/05/12 19:25:37, xiyuan wrote:
> nit: just a return ?
> 
>   return find(api_permissions.begin(), api_permissions.end(), permission) !=
> api_permissions.end();

Done.

https://codereview.chromium.org/1976453002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc:209:
properties |=
On 2016/05/12 19:25:37, xiyuan wrote:
> nit: wrap with {} if condition and branch takes more than one line, here and
> other places.

Done.

[rkc, 2016-05-12 21:46:15]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 21:46:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1976453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1976453002/40001

[rkc, 2016-05-12 22:45:19]

The CQ bit was unchecked by rkc@chromium.org

[rkc, 2016-05-12 22:45:32]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-05-12 22:45:33]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1976453002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-12 22:45:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1976453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1976453002/40001

[commit-bot: I haz the power, 2016-05-12 23:20:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 23:22:05]

Description was changed from

==========
Add permission parsing and the removeService API.

This CL adds and fixes permission and property parsing for local GATT
characteristics and descriptors. It also implements and adds a test for
the removeService API.

R=xiyuan@chromium.org
BUG=611236
==========

to

==========
Add permission parsing and the removeService API.

This CL adds and fixes permission and property parsing for local GATT
characteristics and descriptors. It also implements and adds a test for
the removeService API.

R=xiyuan@chromium.org
BUG=611236

Committed: https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448
Cr-Commit-Position: refs/heads/master@{#393391}
==========

[commit-bot: I haz the power, 2016-05-12 23:22:07]

Patchset 3 (id:??) landed as
https://crrev.com/2ab68fd392b589b868e6e3c441e13a76dc38a448
Cr-Commit-Position: refs/heads/master@{#393391}