IDL changes for BLE GATT server support.

IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742, 611236
Committed: https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e
Cr-Commit-Position: refs/heads/master@{#393381}

[rkc, 2016-05-11 22:42:55]

rkc@chromium.org changed reviewers:
+ mpearson@chromium.org

[rkc, 2016-05-11 22:42:55]

Adding mpearson@ for histograms owners review.

[Mark P, 2016-05-11 22:46:47]

Please add the histograms file for review.

--mark

[Devlin, 2016-05-11 22:47:39]

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:10: 
rm

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:19:
encryptAuthenticatedWrite };
put closing brace on newline (here and line 26)

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:33: enum AdvertisementType
{ broadcast, peripheral };
no need to do this

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:50: notifyPropertyNotSet,
Shouldn't these just be errors?

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:388: // Note, the
characteristic needs to correctly set the notify/indicate
What is the |notify| property?

[rkc, 2016-05-11 22:57:41]

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:10: 
On 2016/05/11 22:47:39, Devlin wrote:
> rm

Done.

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:19:
encryptAuthenticatedWrite };
On 2016/05/11 22:47:39, Devlin wrote:
> put closing brace on newline (here and line 26)

Done.

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:33: enum AdvertisementType
{ broadcast, peripheral };
On 2016/05/11 22:47:39, Devlin wrote:
> no need to do this

Done.

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:50: notifyPropertyNotSet,
On 2016/05/11 22:47:39, Devlin wrote:
> Shouldn't these just be errors?

Sure, no reason these have to be enums here.
Done.

https://codereview.chromium.org/1966893003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/bluetooth_low_energy.idl:388: // Note, the
characteristic needs to correctly set the notify/indicate
On 2016/05/11 22:47:39, Devlin wrote:
> What is the |notify| property?

It is a CharacteristicProperty that we specify while creating a characteristic.
Changed the comment to make this more clear.

[Mark P, 2016-05-11 23:05:50]

histograms.xml lgtm

[rkc, 2016-05-11 23:09:16]

Description was changed from

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742
==========

to

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742,611236
==========

[Devlin, 2016-05-12 00:16:42]

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:365: // indicate is true,
we will send an indication instead of a notification.
who is "we"?

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:367: // 'indicate'
property while creation for this call to succeed.
s/while/during

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:371: //
|characteristicId|: The characteristic to send the notication for.
often for functions like this, a single dictionary parameter is preferred
because it makes it much easier to add new things in the future.

[rkc, 2016-05-12 00:42:32]

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:365: // indicate is true,
we will send an indication instead of a notification.
On 2016/05/12 00:16:41, Devlin wrote:
> who is "we"?

Done.

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:367: // 'indicate'
property while creation for this call to succeed.
On 2016/05/12 00:16:41, Devlin wrote:
> s/while/during

Done.

https://codereview.chromium.org/1966893003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:371: //
|characteristicId|: The characteristic to send the notication for.
On 2016/05/12 00:16:41, Devlin wrote:
> often for functions like this, a single dictionary parameter is preferred
> because it makes it much easier to add new things in the future.

Done.

[Devlin, 2016-05-12 20:58:11]

lgtm

https://codereview.chromium.org/1966893003/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1966893003/diff/80001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:201: boolean? indicate;
nit: naming.  isIndication? shouldBeIndication?  shouldIndicate?

[rkc, 2016-05-12 21:23:36]

https://codereview.chromium.org/1966893003/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1966893003/diff/80001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:201: boolean? indicate;
On 2016/05/12 20:58:11, Devlin wrote:
> nit: naming.  isIndication? shouldBeIndication?  shouldIndicate?

Done.

[rkc, 2016-05-12 21:43:16]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-05-12 21:43:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1966893003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-05-12 21:43:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966893003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966893003/100001

[commit-bot: I haz the power, 2016-05-12 22:42:25]

Description was changed from

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742,611236
==========

to

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742,611236
==========

[commit-bot: I haz the power, 2016-05-12 22:42:27]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-12 22:44:15]

Description was changed from

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742,611236
==========

to

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742,611236

Committed: https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e
Cr-Commit-Position: refs/heads/master@{#393381}
==========

[commit-bot: I haz the power, 2016-05-12 22:44:16]

Patchset 6 (id:??) landed as
https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e
Cr-Commit-Position: refs/heads/master@{#393381}

[rkc, 2016-05-17 19:15:30]

Description was changed from

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742,611236

Committed: https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e
Cr-Commit-Position: refs/heads/master@{#393381}
==========

to

==========
IDL changes for BLE GATT server support.

This CL adds some missing parts from the BTLE IDL required for GATT server
support.

.) It adds the permissions enum for descriptors. Without specifying this,
creating a descriptor has no point, since it can't be read from or written
to.
.) It adds the removeService and the notifyCharactersticValueChanged
functions that are there in the design but were missing from the IDL.

R=rdevlin.cronin@chromium.org
BUG=596742,611236

Committed: https://crrev.com/2f274924652e85ad4adf56bcebba3d6efbce5b3e
Cr-Commit-Position: refs/heads/master@{#393381}
==========