Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6282)

Unified Diff: chrome/installer/util/conditional_work_item_list.h

Issue 1976443005: Revert of Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/callback_work_item.cc ('k') | chrome/installer/util/conditional_work_item_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/conditional_work_item_list.h
diff --git a/chrome/installer/util/conditional_work_item_list.h b/chrome/installer/util/conditional_work_item_list.h
index ba28ca2b83e3e7e08742a5658580a7d41cb1885c..834b1e0df66bdafefb0774cf8962bed6fea69b58 100644
--- a/chrome/installer/util/conditional_work_item_list.h
+++ b/chrome/installer/util/conditional_work_item_list.h
@@ -17,17 +17,15 @@
explicit ConditionalWorkItemList(Condition* condition);
~ConditionalWorkItemList() override;
- private:
- // WorkItemList:
-
// If condition_->ShouldRun() returns true, then execute the items in this
// list and return true iff they all succeed. If condition_->ShouldRun()
// returns false, does nothing and returns true.
- bool DoImpl() override;
+ bool Do() override;
// Does a rollback of the items (if any) that were run in Do.
- void RollbackImpl() override;
+ void Rollback() override;
+ protected:
// Pointer to a Condition that is used to determine whether to run this
// WorkItemList.
std::unique_ptr<Condition> condition_;
« no previous file with comments | « chrome/installer/util/callback_work_item.cc ('k') | chrome/installer/util/conditional_work_item_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698