Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976443002: Fix a sign mismatch. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
Strangely win+gyp works, but win+gn is broken. So are some Chromium Windows bots. Mismatch is ...
4 years, 7 months ago (2016-05-12 03:33:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976443002/1
4 years, 7 months ago (2016-05-12 03:33:39 UTC) #3
Oliver Chang
On 2016/05/12 03:33:18, Lei Zhang wrote: > Strangely win+gyp works, but win+gn is broken. So ...
4 years, 7 months ago (2016-05-12 03:53:25 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 04:08:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/77f45f2376e0baf39144db553c0ede6a5d38...

Powered by Google App Engine
This is Rietveld 408576698