Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 1966293002: Use bytestringC rather than raw ptr/len pairs in syntax parser (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use bytestringC rather than raw ptr/len pairs in syntax parser In particular, we seek to make more use of the .Mid() (substr) method to make these. Precursor to removing c_str() calls. BUG=pdfium:493 Committed: https://pdfium.googlesource.com/pdfium/+/4d063bb820fe934ac38b7805293cbff2919ab325

Patch Set 1 #

Patch Set 2 : Add assert. #

Patch Set 3 : Sentence fragment in comment #

Patch Set 4 : Add comment to fx_string.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 1 2 4 chunks +12 lines, -11 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-11 18:39:33 UTC) #3
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-11 23:07:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966293002/60001
4 years, 7 months ago (2016-05-11 23:09:57 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 23:10:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/4d063bb820fe934ac38b7805293cbff2919a...

Powered by Google App Engine
This is Rietveld 408576698