cc : Fix damage rect bug caused by deletion of render surface

cc : Fix damage rect bug caused by deletion of render surface

The damage tracker tracks if a layer contributed as a layer or surface
and when a surface is removed, it is added to the damage rect.

BUG=611230
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cf22376f77a6c31d4f144f00826b687864031d46
Cr-Commit-Position: refs/heads/master@{#393966}

[jaydasika, 2016-05-13 23:48:49]

Description was changed from

==========
cc : Fix damage rect bug caused by deletion of render surface

The damage tracker tracks if a layer contributed as a layer or surface
and when a surface is removed, it is added to the damage rect.

BUG=611230
==========

to

==========
cc : Fix damage rect bug caused by deletion of render surface

The damage tracker tracks if a layer contributed as a layer or surface
and when a surface is removed, it is added to the damage rect.

BUG=611230
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-05-13 23:54:57]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, danakj@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-05-13 23:54:58]

The modified test passes with this patch. I will add another proper test,
sending it out for review before that to make sure that it is correct.

[ajuma, 2016-05-16 15:16:21]

https://codereview.chromium.org/1976413002/diff/1/cc/trees/damage_tracker.h
File cc/trees/damage_tracker.h (right):

https://codereview.chromium.org/1976413002/diff/1/cc/trees/damage_tracker.h#n...
cc/trees/damage_tracker.h:67: RectMapData() : layer_id_(0), mailboxId_(0),
is_render_surface_(false) {}
How about splitting the map in two, one map for layers and one for surfaces?
Then a change from surface to layer will be handled for free by the logic in
TrackDamageFromLeftoverRects (since we'll have a leftover rect in the surface
map). It also seems like something we'll need to do eventually anyway, to deal
with surfaces no longer being owned by layers.

[jaydasika, 2016-05-16 19:32:01]

Patchset #3 (id:40001) has been deleted

[jaydasika, 2016-05-16 19:32:49]

https://codereview.chromium.org/1976413002/diff/1/cc/trees/damage_tracker.h
File cc/trees/damage_tracker.h (right):

https://codereview.chromium.org/1976413002/diff/1/cc/trees/damage_tracker.h#n...
cc/trees/damage_tracker.h:67: RectMapData() : layer_id_(0), mailboxId_(0),
is_render_surface_(false) {}
On 2016/05/16 15:16:21, ajuma wrote:
> How about splitting the map in two, one map for layers and one for surfaces?
> Then a change from surface to layer will be handled for free by the logic in
> TrackDamageFromLeftoverRects (since we'll have a leftover rect in the surface
> map). It also seems like something we'll need to do eventually anyway, to deal
> with surfaces no longer being owned by layers.

Done.

[ajuma, 2016-05-16 21:33:12]

Thanks, lgtm

[jaydasika, 2016-05-16 22:55:54]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-05-16 22:56:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1976413002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1976413002/60001

[commit-bot: I haz the power, 2016-05-16 23:02:21]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-16 23:03:57]

Description was changed from

==========
cc : Fix damage rect bug caused by deletion of render surface

The damage tracker tracks if a layer contributed as a layer or surface
and when a surface is removed, it is added to the damage rect.

BUG=611230
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Fix damage rect bug caused by deletion of render surface

The damage tracker tracks if a layer contributed as a layer or surface
and when a surface is removed, it is added to the damage rect.

BUG=611230
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cf22376f77a6c31d4f144f00826b687864031d46
Cr-Commit-Position: refs/heads/master@{#393966}
==========

[commit-bot: I haz the power, 2016-05-16 23:03:58]

Patchset 3 (id:??) landed as
https://crrev.com/cf22376f77a6c31d4f144f00826b687864031d46
Cr-Commit-Position: refs/heads/master@{#393966}