Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: cc/trees/damage_tracker.h

Issue 1976413002: cc : Fix damage rect bug caused by deletion of render surface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/texture_layer_unittest.cc ('k') | cc/trees/damage_tracker.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_DAMAGE_TRACKER_H_ 5 #ifndef CC_TREES_DAMAGE_TRACKER_H_
6 #define CC_TREES_DAMAGE_TRACKER_H_ 6 #define CC_TREES_DAMAGE_TRACKER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 gfx::Rect TrackDamageFromSurfaceMask(LayerImpl* target_surface_mask_layer); 56 gfx::Rect TrackDamageFromSurfaceMask(LayerImpl* target_surface_mask_layer);
57 gfx::Rect TrackDamageFromLeftoverRects(); 57 gfx::Rect TrackDamageFromLeftoverRects();
58 58
59 void PrepareRectHistoryForUpdate(); 59 void PrepareRectHistoryForUpdate();
60 60
61 // These helper functions are used only in TrackDamageFromActiveLayers(). 61 // These helper functions are used only in TrackDamageFromActiveLayers().
62 void ExtendDamageForLayer(LayerImpl* layer, gfx::Rect* target_damage_rect); 62 void ExtendDamageForLayer(LayerImpl* layer, gfx::Rect* target_damage_rect);
63 void ExtendDamageForRenderSurface(LayerImpl* layer, 63 void ExtendDamageForRenderSurface(LayerImpl* layer,
64 gfx::Rect* target_damage_rect); 64 gfx::Rect* target_damage_rect);
65 65
66 struct RectMapData { 66 struct LayerRectMapData {
67 RectMapData() : layer_id_(0), mailboxId_(0) {} 67 LayerRectMapData() : layer_id_(0), mailboxId_(0) {}
68 explicit RectMapData(int layer_id) : layer_id_(layer_id), mailboxId_(0) {} 68 explicit LayerRectMapData(int layer_id)
69 : layer_id_(layer_id), mailboxId_(0) {}
69 void Update(const gfx::Rect& rect, unsigned int mailboxId) { 70 void Update(const gfx::Rect& rect, unsigned int mailboxId) {
70 mailboxId_ = mailboxId; 71 mailboxId_ = mailboxId;
71 rect_ = rect; 72 rect_ = rect;
72 } 73 }
73 74
74 bool operator < (const RectMapData& other) const { 75 bool operator<(const LayerRectMapData& other) const {
75 return layer_id_ < other.layer_id_; 76 return layer_id_ < other.layer_id_;
76 } 77 }
77 78
78 int layer_id_; 79 int layer_id_;
79 unsigned int mailboxId_; 80 unsigned int mailboxId_;
80 gfx::Rect rect_; 81 gfx::Rect rect_;
81 }; 82 };
82 typedef std::vector<RectMapData> SortedRectMap;
83 83
84 RectMapData& RectDataForLayer(int layer_id, bool* layer_is_new); 84 struct SurfaceRectMapData {
85 SurfaceRectMapData() : surface_id_(0), mailboxId_(0) {}
86 explicit SurfaceRectMapData(int surface_id)
87 : surface_id_(surface_id), mailboxId_(0) {}
88 void Update(const gfx::Rect& rect, unsigned int mailboxId) {
89 mailboxId_ = mailboxId;
90 rect_ = rect;
91 }
85 92
86 SortedRectMap rect_history_; 93 bool operator<(const SurfaceRectMapData& other) const {
94 return surface_id_ < other.surface_id_;
95 }
96
97 int surface_id_;
98 unsigned int mailboxId_;
99 gfx::Rect rect_;
100 };
101 typedef std::vector<LayerRectMapData> SortedRectMapForLayers;
102 typedef std::vector<SurfaceRectMapData> SortedRectMapForSurfaces;
103
104 LayerRectMapData& RectDataForLayer(int layer_id, bool* layer_is_new);
105 SurfaceRectMapData& RectDataForSurface(int layer_id, bool* layer_is_new);
106
107 SortedRectMapForLayers rect_history_for_layers_;
108 SortedRectMapForSurfaces rect_history_for_surfaces_;
87 109
88 unsigned int mailboxId_; 110 unsigned int mailboxId_;
89 gfx::Rect current_damage_rect_; 111 gfx::Rect current_damage_rect_;
90 112
91 DISALLOW_COPY_AND_ASSIGN(DamageTracker); 113 DISALLOW_COPY_AND_ASSIGN(DamageTracker);
92 }; 114 };
93 115
94 } // namespace cc 116 } // namespace cc
95 117
96 #endif // CC_TREES_DAMAGE_TRACKER_H_ 118 #endif // CC_TREES_DAMAGE_TRACKER_H_
OLDNEW
« no previous file with comments | « cc/layers/texture_layer_unittest.cc ('k') | cc/trees/damage_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698