Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/renderer/p2p/port_allocator.h

Issue 1976263002: Stop asynchronously deleting the network manager in P2PPortAllocator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/p2p/port_allocator.h
diff --git a/content/renderer/p2p/port_allocator.h b/content/renderer/p2p/port_allocator.h
index 945b5f87e6e5a40aa94664783d255fcce1206729..71a1f6111922ee93e3a3e785e8506b5f7dac4b70 100644
--- a/content/renderer/p2p/port_allocator.h
+++ b/content/renderer/p2p/port_allocator.h
@@ -38,13 +38,11 @@ class P2PPortAllocator : public cricket::BasicPortAllocator {
bool enable_default_local_candidate = true;
};
- P2PPortAllocator(
- const scoped_refptr<P2PSocketDispatcher>& socket_dispatcher,
- std::unique_ptr<rtc::NetworkManager> network_manager,
- rtc::PacketSocketFactory* socket_factory,
- const Config& config,
- const GURL& origin,
- const scoped_refptr<base::SingleThreadTaskRunner> task_runner);
+ P2PPortAllocator(const scoped_refptr<P2PSocketDispatcher>& socket_dispatcher,
+ std::unique_ptr<rtc::NetworkManager> network_manager,
+ rtc::PacketSocketFactory* socket_factory,
+ const Config& config,
+ const GURL& origin);
~P2PPortAllocator() override;
private:
@@ -53,11 +51,6 @@ class P2PPortAllocator : public cricket::BasicPortAllocator {
Config config_;
GURL origin_;
- // This is the thread |network_manager_| is associated with and must be used
- // to delete |network_manager_|.
- const scoped_refptr<base::SingleThreadTaskRunner>
- network_manager_task_runner_;
-
DISALLOW_COPY_AND_ASSIGN(P2PPortAllocator);
};

Powered by Google App Engine
This is Rietveld 408576698