content/renderer/media/webrtc/peer_connection_dependency_factory.cc - Issue 1976263002: Stop asynchronously deleting the network manager in P2PPortAllocator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 1976263002: Stop asynchronously deleting the network manager in P2PPortAllocator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

index 2c7bb074127a115c10a96ffa9b455f81d904a0b0..8a63dca8938e1edebaf946cdbce5bc382bdfc5db 100644

--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

@@ -401,7 +401,7 @@ PeerConnectionDependencyFactory::CreatePeerConnection(

}

std::unique_ptr<P2PPortAllocator> port_allocator(new P2PPortAllocator(

p2p_socket_dispatcher_, std::move(network_manager), socket_factory_.get(),

- port_config, requesting_origin, chrome_worker_thread_.task_runner()));

+ port_config, requesting_origin));

return GetPcFactory()

->CreatePeerConnection(config, std::move(port_allocator),

« no previous file with comments | « no previous file | content/renderer/p2p/port_allocator.h » ('j') | content/renderer/p2p/port_allocator.cc » ('J')