Add TextTrack::isVisualKind helper

Add TextTrack::isVisualKind helper

It's quite common to check for a text track being one of the kinds
'subtitles' or 'captions'. Add a helper to TextTrack and use that
in a bunch of places to simplify code.
Also convert one open-coded version of TextTrack::canBeRendered() with a
call to that method.

Committed: https://crrev.com/d18abb5e4780c7d6d429f72a5d566f6a894d5013
Cr-Commit-Position: refs/heads/master@{#393814}

[fs, 2016-05-13 17:12:06]

fs@opera.com changed reviewers:
+ davve@opera.com

[davve, 2016-05-16 07:08:26]

Syntax error when parsing first sentence of description, an 'of' too many?

A couple of De Morgan's in my head later and I've convinced myself this nice
cleanup is correct. lgtm.

[fs, 2016-05-16 08:11:29]

Description was changed from

==========
Add TextTrack::isVisualKind helper

It's quite common to check for a text track being either of one of the
kinds 'subtitles' or 'captions'. Add a helper to TextTrack and use that
in a bunch of places to simplify code.
Also convert one open-coded version of TextTrack::canBeRendered() with a
call to that method.
==========

to

==========
Add TextTrack::isVisualKind helper

It's quite common to check for a text track being one of the kinds
'subtitles' or 'captions'. Add a helper to TextTrack and use that
in a bunch of places to simplify code.
Also convert one open-coded version of TextTrack::canBeRendered() with a
call to that method.
==========

[fs, 2016-05-16 08:11:46]

On 2016/05/16 at 07:08:26, davve wrote:
> Syntax error when parsing first sentence of description, an 'of' too many?

I dropped both 'either' and 'of'.

[fs, 2016-05-16 08:12:17]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-05-16 08:12:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1976183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1976183002/20001

[commit-bot: I haz the power, 2016-05-16 10:13:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-16 10:14:48]

Description was changed from

==========
Add TextTrack::isVisualKind helper

It's quite common to check for a text track being one of the kinds
'subtitles' or 'captions'. Add a helper to TextTrack and use that
in a bunch of places to simplify code.
Also convert one open-coded version of TextTrack::canBeRendered() with a
call to that method.
==========

to

==========
Add TextTrack::isVisualKind helper

It's quite common to check for a text track being one of the kinds
'subtitles' or 'captions'. Add a helper to TextTrack and use that
in a bunch of places to simplify code.
Also convert one open-coded version of TextTrack::canBeRendered() with a
call to that method.

Committed: https://crrev.com/d18abb5e4780c7d6d429f72a5d566f6a894d5013
Cr-Commit-Position: refs/heads/master@{#393814}
==========

[commit-bot: I haz the power, 2016-05-16 10:14:49]

Patchset 2 (id:??) landed as
https://crrev.com/d18abb5e4780c7d6d429f72a5d566f6a894d5013
Cr-Commit-Position: refs/heads/master@{#393814}