Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1976183002: Add TextTrack::isVisualKind helper (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
Reviewers:
davve
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TextTrack::isVisualKind helper It's quite common to check for a text track being one of the kinds 'subtitles' or 'captions'. Add a helper to TextTrack and use that in a bunch of places to simplify code. Also convert one open-coded version of TextTrack::canBeRendered() with a call to that method. Committed: https://crrev.com/d18abb5e4780c7d6d429f72a5d566f6a894d5013 Cr-Commit-Position: refs/heads/master@{#393814}

Patch Set 1 #

Patch Set 2 : One more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 3 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
fs
4 years, 7 months ago (2016-05-13 17:12:06 UTC) #2
davve
Syntax error when parsing first sentence of description, an 'of' too many? A couple of ...
4 years, 7 months ago (2016-05-16 07:08:26 UTC) #3
fs
On 2016/05/16 at 07:08:26, davve wrote: > Syntax error when parsing first sentence of description, ...
4 years, 7 months ago (2016-05-16 08:11:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976183002/20001
4 years, 7 months ago (2016-05-16 08:12:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 10:13:36 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 10:14:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d18abb5e4780c7d6d429f72a5d566f6a894d5013
Cr-Commit-Position: refs/heads/master@{#393814}

Powered by Google App Engine
This is Rietveld 408576698