third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp - Issue 1976183002: Add TextTrack::isVisualKind helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp

Issue 1976183002: Add TextTrack::isVisualKind helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/track/TextTrack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp

diff --git a/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp b/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp

index c226541e03957dcb08789aeb38a8f0597e4b7f14..4026fdb757964095844978a582ec141c339e44b0 100644

--- a/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp

+++ b/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp

@@ -50,7 +50,7 @@ static int textTrackLanguageSelectionScore(const TextTrack& track)

static int textTrackSelectionScore(const TextTrack& track)

{

- if (track.kind() != TextTrack::captionsKeyword() && track.kind() != TextTrack::subtitlesKeyword())

+ if (!track.isVisualKind())

return 0;

return textTrackLanguageSelectionScore(track);

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/track/TextTrack.h » ('j') | no next file with comments »