xfa/fxfa/include/fxfa.h - Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/include/fxfa.h

Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/include/fxfa.h

diff --git a/xfa/fxfa/include/fxfa.h b/xfa/fxfa/include/fxfa.h

index a7d1a282ba37d02159af5075a2acccb3d9063c37..740658c8c81e473c6913958b84de55b9381faca2 100644

--- a/xfa/fxfa/include/fxfa.h

+++ b/xfa/fxfa/include/fxfa.h

@@ -536,7 +536,8 @@ class CXFA_RenderOptions {

class IXFA_WidgetIterator {

public:

- virtual void Release() = 0;

+ virtual ~IXFA_WidgetIterator() {}

virtual void Reset() = 0;

virtual CXFA_FFWidget* MoveToFirst() = 0;

virtual CXFA_FFWidget* MoveToLast() = 0;

@@ -544,9 +545,6 @@ class IXFA_WidgetIterator {

virtual CXFA_FFWidget* MoveToPrevious() = 0;

virtual CXFA_FFWidget* GetCurrentWidget() = 0;

virtual FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) = 0;

- protected:

- virtual ~IXFA_WidgetIterator() {}

};

#endif // XFA_FXFA_INCLUDE_FXFA_H_

« fpdfsdk/fsdk_mgr.cpp ('K') | « xfa/fxfa/app/xfa_rendercontext.cpp ('k') | xfa/fxfa/include/xfa_ffdocview.h » ('j') | no next file with comments »