Remove { delete this; } anti-pattern from IXFA_WidgetIterator

fpdfsdk/fsdk_mgr.cpp

Index: fpdfsdk/fsdk_mgr.cpp
diff --git a/fpdfsdk/fsdk_mgr.cpp b/fpdfsdk/fsdk_mgr.cpp
index 4ab4850c4d477fe0e8c504cc9cff5a421cfb91c4..54701c22ee463ad4d8606cd426cb3152681b5dc2 100644
--- a/fpdfsdk/fsdk_mgr.cpp
+++ b/fpdfsdk/fsdk_mgr.cpp
@@ -905,12 +905,12 @@ void CPDFSDK_PageView::LoadFXAnnots() {
   m_page->AddRef();
   if (m_pSDKDoc->GetXFADocument()->GetDocType() == DOCTYPE_DYNAMIC_XFA) {
     CXFA_FFPageView* pageView = m_page->GetXFAPageView();
-    IXFA_WidgetIterator* pWidgetHander = pageView->CreateWidgetIterator(
-        XFA_TRAVERSEWAY_Form, XFA_WIDGETFILTER_Visible |
-                                  XFA_WIDGETFILTER_Viewable |
-                                  XFA_WIDGETFILTER_AllType);
+    std::unique_ptr<IXFA_WidgetIterator> pWidgetHander(
+        pageView->CreateWidgetIterator(XFA_TRAVERSEWAY_Form,
+                                       XFA_WIDGETFILTER_Visible |
+                                           XFA_WIDGETFILTER_Viewable |
+                                           XFA_WIDGETFILTER_AllType));
     if (!pWidgetHander) {
-      m_page->Release();

[Lei Zhang, 2016/05/14 00:43:53]

Isn't this still needed to balance out line 905?

[Tom Sepez, 2016/05/16 16:15:58]

Acknowledged. Done.

       SetLock(FALSE);
       return;
     }
@@ -919,11 +919,9 @@ void CPDFSDK_PageView::LoadFXAnnots() {
       CPDFSDK_Annot* pAnnot = pAnnotHandlerMgr->NewAnnot(pXFAAnnot, this);
       if (!pAnnot)
         continue;
-
       m_fxAnnotArray.push_back(pAnnot);
       pAnnotHandlerMgr->Annot_OnLoad(pAnnot);
     }
-    pWidgetHander->Release();
   } else {
     CPDF_Page* pPage = m_page->GetPDFPage();
     ASSERT(pPage);