fpdfsdk/fpdfformfill.cpp - Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfformfill.cpp

Issue 1976123003: Remove { delete this; } anti-pattern from IXFA_WidgetIterator (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/fpdfformfill.cpp

diff --git a/fpdfsdk/fpdfformfill.cpp b/fpdfsdk/fpdfformfill.cpp

index 153c1057a576b9e4836c6ac7d2e22ab514c537fb..94a8bf12a5e0a4dbf6bb8b7432316a9a266f5dfb 100644

--- a/fpdfsdk/fpdfformfill.cpp

+++ b/fpdfsdk/fpdfformfill.cpp

@@ -91,8 +91,8 @@ DLLEXPORT int STDCALL FPDFPage_HasFormFieldAtPoint(FPDF_FORMHANDLE hHandle,

if (!pWidgetHandler)

return -1;

- std::unique_ptr<IXFA_WidgetIterator, ReleaseDeleter<IXFA_WidgetIterator>>

- pWidgetIterator(pPageView->CreateWidgetIterator(

+ std::unique_ptr<IXFA_WidgetIterator> pWidgetIterator(

+ pPageView->CreateWidgetIterator(

XFA_TRAVERSEWAY_Form,

XFA_WIDGETFILTER_Viewable | XFA_WIDGETFILTER_AllType));

if (!pWidgetIterator)

« no previous file with comments | « no previous file | fpdfsdk/fsdk_annothandler.cpp » ('j') | fpdfsdk/fsdk_mgr.cpp » ('J')