Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 1975993002: Change InterfaceFactory<I>::Create() to take a ConnectionContext instead of an ApplicationConnectio… (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change InterfaceFactory<I>::Create() to take a ConnectionContext instead of an ApplicationConnection. This is part of a long road to nuke ApplicationConnection and InterfaceFactory (!) from orbit. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d21f93b751a5eef50069f02c0768c41c059f7522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -255 lines) Patch
M apps/moterm/moterm_view.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/moterm_view.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M examples/apptest/example_service_application.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/apptest/example_service_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/bank_app/bank.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo/echo_server.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M examples/echo_terminal/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/hello_mojo/hello_mojo_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/indirect_service/indirect_integer_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/indirect_service/integer_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/native_run_app/native_run_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/interface_factory.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/lib/interface_factory_connector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/lib/service_connector_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/lib/service_connector_registry.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/lib/service_provider_impl.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M mojo/public/cpp/application/lib/service_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/service_connector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/service_provider_impl.h View 3 chunks +6 lines, -11 lines 0 comments Download
M mojo/public/cpp/application/tests/service_provider_impl_unittest.cc View 5 chunks +49 lines, -13 lines 0 comments Download
M mojo/public/cpp/application/tests/service_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/ui/content_viewer_app.h View 2 chunks +13 lines, -15 lines 0 comments Download
M mojo/ui/content_viewer_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/ui/view_provider_app.h View 2 chunks +18 lines, -20 lines 0 comments Download
M mojo/ui/view_provider_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/asset_bundle/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/authentication/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/clipboard/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/device_info/device_info.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/files/files_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M services/files/files_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/files/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/gfx/compositor/compositor_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/compositor_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/icu_data/icu_data_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/keyboard/linux/main.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/log/log_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/log/log_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M services/log/log_impl_unittest.cc View 1 chunk +3 lines, -29 lines 0 comments Download
M services/log/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/media/audio/audio_server_app.h View 2 chunks +6 lines, -7 lines 0 comments Download
M services/media/audio/audio_server_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/media/factory_service/factory_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/factory_service/factory_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/nonsfi/pnacl_compile.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/nonsfi/pnacl_link.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/native_support/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_support/process_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/native_support/process_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/native_viewport/app_delegate.h View 2 chunks +12 lines, -14 lines 0 comments Download
M services/native_viewport/app_delegate.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M services/prediction/prediction_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/prediction_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/test_service/test_request_tracker_application.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/test_service/test_service_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/test_service/test_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/tracing_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/tracing_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/input_manager/input_manager_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_manager/input_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/launcher/launcher_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/launcher/launcher_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/view_manager/view_manager_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/view_manager/view_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M shell/android/native_viewport_application_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/android/native_viewport_application_loader.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M shell/test/pingable_app.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc View 1 chunk +8 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
Sorry for the size of the change. The "interesting" parts are under mojo/public/cpp/application. The rest ...
4 years, 7 months ago (2016-05-12 21:57:16 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-12 23:34:25 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-12 23:35:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d21f93b751a5eef50069f02c0768c41c059f7522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698