mojo/public/cpp/application/lib/service_connector_registry.h - Issue 1975993002: Change InterfaceFactory<I>::Create() to take a ConnectionContext instead of an ApplicationConnectio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/application/lib/service_connector_registry.h

Issue 1975993002: Change InterfaceFactory<I>::Create() to take a ConnectionContext instead of an ApplicationConnectio… (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/application/lib/interface_factory_connector.h ('k') | mojo/public/cpp/application/lib/service_connector_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/application/lib/service_connector_registry.h

diff --git a/mojo/public/cpp/application/lib/service_connector_registry.h b/mojo/public/cpp/application/lib/service_connector_registry.h

index b66d379d5f4921703f9fcd68bf87b7d9f6e0b714..235d34d5bd9a062a07b4bde1146546b7b3973282 100644

--- a/mojo/public/cpp/application/lib/service_connector_registry.h

+++ b/mojo/public/cpp/application/lib/service_connector_registry.h

@@ -13,7 +13,7 @@

namespace mojo {

-class ApplicationConnection;

+struct ConnectionContext;

class ServiceConnector;

namespace internal {

@@ -40,7 +40,7 @@ class ServiceConnectorRegistry {

// |interface_name|. In that case, the |client_handle| is passed along

// to the |ServiceConnector|. Otherwise, this function returns false and

// |client_handle| is untouched.

- bool ConnectToService(ApplicationConnection* application_connection,

+ bool ConnectToService(const ConnectionContext& connection_context,

const std::string& interface_name,

ScopedMessagePipeHandle* client_handle);