Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1975963002: Support the name analysis_options.yaml for analysis options files (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support the name analysis_options.yaml for analysis options files R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/44836f85381196458936c12a6d4d234f0e66bd80

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2582 lines, -2368 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 4 chunks +18 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +22 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 5 chunks +2175 lines, -2137 lines 1 comment Download
M pkg/analysis_server/test/integration/analysis/analysis_options_test.dart View 2 chunks +31 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/lint_test.dart View 2 chunks +33 lines, -3 lines 0 comments Download
M pkg/analyzer/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/README.md View 1 chunk +13 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/options_work_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 7 chunks +22 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 2 chunks +13 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/options_work_manager_test.dart View 2 chunks +22 lines, -8 lines 0 comments Download
M pkg/analyzer_cli/lib/src/boot_loader.dart View 3 chunks +20 lines, -5 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/analyzer_cli/lib/src/plugin/plugin_manager.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analyzer_cli/test/data/linter_project/analysis_options.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analyzer_cli/test/data/no_lints_project/analysis_options.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analyzer_cli/test/data/options_tests_project/analysis_options.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 2 chunks +172 lines, -158 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Both names are recognized, and the old name takes precedence over the new name if ...
4 years, 7 months ago (2016-05-12 18:47:48 UTC) #2
scheglov
lgtm
4 years, 7 months ago (2016-05-12 19:34:24 UTC) #3
Brian Wilkerson
4 years, 7 months ago (2016-05-13 14:33:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44836f85381196458936c12a6d4d234f0e66bd80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698