Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: pkg/analyzer/lib/src/task/options.dart

Issue 1975963002: Support the name analysis_options.yaml for analysis options files (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/options.dart
diff --git a/pkg/analyzer/lib/src/task/options.dart b/pkg/analyzer/lib/src/task/options.dart
index 47acf37f43b8e3feeb522f01ee908db72824abb7..fd1c224ef8d92a256d2d8b2c7a63c79f5ec203b8 100644
--- a/pkg/analyzer/lib/src/task/options.dart
+++ b/pkg/analyzer/lib/src/task/options.dart
@@ -21,7 +21,7 @@ import 'package:analyzer/task/model.dart';
import 'package:source_span/source_span.dart';
import 'package:yaml/yaml.dart';
-/// The errors produced while parsing `.analysis_options` files.
+/// The errors produced while parsing an analysis options file.
///
/// The list will be empty if there were no errors, but will not be `null`.
final ListResultDescriptor<AnalysisError> ANALYSIS_OPTIONS_ERRORS =
@@ -204,7 +204,7 @@ class ErrorFilterOptionValidator extends OptionsValidator {
}
}
-/// A task that generates errors for an `.analysis_options` file.
+/// A task that generates errors for an analysis options file.
class GenerateOptionsErrorsTask extends SourceBasedAnalysisTask {
/// The name of the input whose value is the content of the file.
static const String CONTENT_INPUT_NAME = 'CONTENT_INPUT_NAME';
@@ -276,7 +276,8 @@ class GenerateOptionsErrorsTask extends SourceBasedAnalysisTask {
*/
static TaskSuitability suitabilityFor(AnalysisTarget target) {
if (target is Source &&
- target.shortName == AnalysisEngine.ANALYSIS_OPTIONS_FILE) {
+ (target.shortName == AnalysisEngine.ANALYSIS_OPTIONS_FILE ||
+ target.shortName == AnalysisEngine.ANALYSIS_OPTIONS_YAML_FILE)) {
return TaskSuitability.HIGHEST;
}
return TaskSuitability.NONE;
@@ -324,7 +325,7 @@ class LinterOptionsValidator extends TopLevelOptionValidator {
LinterOptionsValidator() : super('linter', const ['rules']);
}
-/// Validates options defined in an `.analysis_options` file.
+/// Validates options defined in an analysis options file.
class OptionsFileValidator {
// TODO(pq): move to an extension point.
final List<OptionsValidator> _validators = [

Powered by Google App Engine
This is Rietveld 408576698