Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Issue 1975793002: Checkdeps update to default to resolve_dotdot. (Closed)

Created:
4 years, 7 months ago by smaier
Modified:
4 years, 7 months ago
Reviewers:
brettw, agrieve
Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

Checkdeps update to default to resolve_dotdot. The presubmit run by "git cl presubmit" creates a DepsChecker via PRESUBMIT.py, but some build bots run checkdeps.py directly. This change fixes running checkdeps.py to allow resolve_dotdot to be set by default. BUG=332521 R=agrieve@chromium.org, brettw@chromium.org Committed: c646464cd87f39c83a7bdec52f1895fd0709a169

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changing DepsChecker constructor to resolve_dotdot=True by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M checkdeps/checkdeps.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
smaier
brettw@chromium.org: Please review changes in checkdeps.py
4 years, 7 months ago (2016-05-12 14:29:43 UTC) #2
agrieve
lgtm. just one idea. https://codereview.chromium.org/1975793002/diff/1/checkdeps/checkdeps.py File checkdeps/checkdeps.py (right): https://codereview.chromium.org/1975793002/diff/1/checkdeps/checkdeps.py#newcode46 checkdeps/checkdeps.py:46: resolve_dotdot=False): nit: can you change ...
4 years, 7 months ago (2016-05-12 14:32:14 UTC) #3
smaier
https://codereview.chromium.org/1975793002/diff/1/checkdeps/checkdeps.py File checkdeps/checkdeps.py (right): https://codereview.chromium.org/1975793002/diff/1/checkdeps/checkdeps.py#newcode46 checkdeps/checkdeps.py:46: resolve_dotdot=False): On 2016/05/12 14:32:14, agrieve wrote: > nit: can ...
4 years, 7 months ago (2016-05-12 14:46:48 UTC) #4
brettw
lgtm
4 years, 7 months ago (2016-05-12 16:37:12 UTC) #5
agrieve
4 years, 7 months ago (2016-05-12 16:55:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c646464cd87f39c83a7bdec52f1895fd0709a169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698