checkdeps/checkdeps.py - Issue 1975793002: Checkdeps update to default to resolve_dotdot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: checkdeps/checkdeps.py

Issue 1975793002: Checkdeps update to default to resolve_dotdot. (Closed) Base URL: https://chromium.googlesource.com/chromium/buildtools.git@master

Patch Set: Changing DepsChecker constructor to resolve_dotdot=True by default Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: checkdeps/checkdeps.py

diff --git a/checkdeps/checkdeps.py b/checkdeps/checkdeps.py

index d61643d708b87fed60f2cb9357722b60da0ef4e6..28ac571933fe1d6e997e54fcdf12689b6ee0bd78 100755

--- a/checkdeps/checkdeps.py

+++ b/checkdeps/checkdeps.py

@@ -43,7 +43,7 @@ class DepsChecker(DepsBuilder):

being_tested=False,

ignore_temp_rules=False,

skip_tests=False,

- resolve_dotdot=False):

+ resolve_dotdot=True):

"""Creates a new DepsChecker.

Args:

@@ -179,8 +179,8 @@ def main():

'', '--json',

help='Path to JSON output file')

option_parser.add_option(

- '', '--resolve-dotdot',

- action='store_true', dest='resolve_dotdot', default=False,

+ '', '--no-resolve-dotdot',

+ action='store_false', dest='resolve_dotdot', default=True,

help='resolve leading ../ in include directive paths relative '

'to the file perfoming the inclusion.')

« no previous file with comments | « no previous file | no next file » | no next file with comments »