Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1975753005: Remove NVPR related env var from command buffer GL context creation (Closed)

Created:
4 years, 7 months ago by Kimmo Kinnunen
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@command-buffer-egl-display
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove NVPR related env var from command buffer GL context creation NVPR is now enabled by default for Chromium command buffer. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1975753005 Committed: https://skia.googlesource.com/skia/+/4803f9715ff02b54a8ebae24167c490181d7cc3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Kimmo Kinnunen
4 years, 7 months ago (2016-05-13 06:43:20 UTC) #3
bsalomon
lgtm
4 years, 7 months ago (2016-05-13 13:11:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975753005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975753005/1
4 years, 7 months ago (2016-05-17 13:13:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/8651)
4 years, 7 months ago (2016-05-17 14:02:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975753005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975753005/1
4 years, 7 months ago (2016-05-18 05:02:45 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 05:15:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4803f9715ff02b54a8ebae24167c490181d7cc3f

Powered by Google App Engine
This is Rietveld 408576698