Remove workarounds initializing command buffer EGL

Remove workarounds initializing command buffer EGL

The eglDisplay() of command buffer EGL implementation now does not
allocate a new EGL display per call, rather just returns the global.

The EGL implementation is fixed as part of bug 581634.

Removes eglTerminate call, as it's should not be used in Skia at the
moment. The call will terminate all of EGL, which is not intendend. The
previous usage was only due to incorrect implementation of the API.  Not
added back to anywhere else, leaking EGL globals is as
designed. Discussed in https://chromiumcodereview.appspot.com/1733323002.

BUG=581634, 603223
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978733003

Committed: https://skia.googlesource.com/skia/+/aac0cb07ca44b116f9cd0c5b78cbcb795a6dec97

[Kimmo Kinnunen, 2016-05-13 06:40:04]

Description was changed from

==========
Remove workarounds initializing command buffer EGL

The eglDisplay() of command buffer EGL implementation now does not
allocate a new EGL display per call, rather just returns the global.

The EGL implementation is fixed as part of bug 581634.

Removes eglTerminate call, as it's should not be used in Skia at the
moment. The call will terminate all of EGL, which is not intendend. The
previous usage was only due to incorrect implementation of the API.  Not
added back to anywhere else, leaking EGL globals is as
designed. Discussed in https://chromiumcodereview.appspot.com/1733323002.

BUG=581634, 603223
==========

to

==========
Remove workarounds initializing command buffer EGL

The eglDisplay() of command buffer EGL implementation now does not
allocate a new EGL display per call, rather just returns the global.

The EGL implementation is fixed as part of bug 581634.

Removes eglTerminate call, as it's should not be used in Skia at the
moment. The call will terminate all of EGL, which is not intendend. The
previous usage was only due to incorrect implementation of the API.  Not
added back to anywhere else, leaking EGL globals is as
designed. Discussed in https://chromiumcodereview.appspot.com/1733323002.

BUG=581634, 603223
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Kimmo Kinnunen, 2016-05-13 06:41:11]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com

[Kimmo Kinnunen, 2016-05-13 06:41:12]

If the commit https://chromiumcodereview.appspot.com/1733323002 sticks for few
more days, this could be applicable.

[bsalomon, 2016-05-13 13:12:52]

lgtm, feel free to land when you think the Chromium change has stuck.

[Kimmo Kinnunen, 2016-05-17 07:36:48]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2016-05-17 07:36:48]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1978733003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-17 07:36:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1978733003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1978733003/20001

[commit-bot: I haz the power, 2016-05-17 13:01:43]

Description was changed from

==========
Remove workarounds initializing command buffer EGL

The eglDisplay() of command buffer EGL implementation now does not
allocate a new EGL display per call, rather just returns the global.

The EGL implementation is fixed as part of bug 581634.

Removes eglTerminate call, as it's should not be used in Skia at the
moment. The call will terminate all of EGL, which is not intendend. The
previous usage was only due to incorrect implementation of the API.  Not
added back to anywhere else, leaking EGL globals is as
designed. Discussed in https://chromiumcodereview.appspot.com/1733323002.

BUG=581634, 603223
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove workarounds initializing command buffer EGL

The eglDisplay() of command buffer EGL implementation now does not
allocate a new EGL display per call, rather just returns the global.

The EGL implementation is fixed as part of bug 581634.

Removes eglTerminate call, as it's should not be used in Skia at the
moment. The call will terminate all of EGL, which is not intendend. The
previous usage was only due to incorrect implementation of the API.  Not
added back to anywhere else, leaking EGL globals is as
designed. Discussed in https://chromiumcodereview.appspot.com/1733323002.

BUG=581634, 603223
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/aac0cb07ca44b116f9cd0c5b78cbcb795a6dec97
==========

[commit-bot: I haz the power, 2016-05-17 13:01:44]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/aac0cb07ca44b116f9cd0c5b78cbcb795a6dec97