Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1975673002: Set SkipServiceWorker flag in DocumentThreadableLoader::loadActualRequest(). (Closed)

Created:
4 years, 7 months ago by horo
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Set SkipServiceWorker flag in DocumentThreadableLoader::loadActualRequest(). Before a SW controls the page, when the DTL sends a CORS preflight request, the SkipServiceWorker flag is set by RenderFrameImpl::willSendRequest(). But a new SW may be controlling the page when the DTL sends the actual request by calling clients.claim(). In such case, the request goes to the SW and causes several problems. To avoid this problem, this cl set the flag in DTL::loadActualRequest(). BUG=604583, 610400 Review-Url: https://codereview.chromium.org/1964823002 Cr-Commit-Position: refs/heads/master@{#392609} (cherry picked from commit 01fb3c2cf2bf84391c488f3a3dd5ef8c59cc0a51) Committed: https://chromium.googlesource.com/chromium/src/+/b083560ed010859fb4cdd23626ddef597d40b1f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
horo
4 years, 7 months ago (2016-05-12 02:19:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b083560ed010859fb4cdd23626ddef597d40b1f4 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698