Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 1975673002: Set SkipServiceWorker flag in DocumentThreadableLoader::loadActualRequest(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
index aba263d5cb7b3445563896e24b5ab1465a614c63..104f36bd8048b7ac1107fb458d576171d6e446c8 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
@@ -789,6 +789,12 @@ void DocumentThreadableLoader::loadActualRequest()
clearResource();
+ // Explicitly set the SkipServiceWorker flag here. Even if the page was not
+ // controlled by a SW when the preflight request was sent, a new SW may be
+ // controlling the page now by calling clients.claim(). We should not send
+ // the actual request to the SW. https://crbug.com/604583
+ actualRequest.setSkipServiceWorker(true);
+
loadRequest(actualRequest, actualOptions);
// |this| may be dead here in async mode.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698