Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1975563002: [DevTools] Move device outline out of experiment. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device-outline-fixes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move device outline out of experiment. BUG=411892 Committed: https://crrev.com/9606139204968a4bbcf29d2ebe80698e389a060c Cr-Commit-Position: refs/heads/master@{#393189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1969913002 Patch 40001

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-05-11 23:34:40 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-11 23:35:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975563002/1
4 years, 7 months ago (2016-05-12 02:36:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 05:22:50 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 05:23:51 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9606139204968a4bbcf29d2ebe80698e389a060c
Cr-Commit-Position: refs/heads/master@{#393189}

Powered by Google App Engine
This is Rietveld 408576698