Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969913002: [DevTools] Polish device mode UI, include outline into screenshot. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Polish device mode UI, include outline into screenshot. BUG=411892 Committed: https://crrev.com/289ae075201b056bed74bd4dbeebe290c4494450 Cr-Commit-Position: refs/heads/master@{#393156}

Patch Set 1 #

Patch Set 2 : rulers + outline look nice #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -73 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 7 chunks +25 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 2 12 chunks +56 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 1 4 chunks +61 lines, -10 lines 0 comments Download

Dependent Patchsets:

Issue 1975563002 Patch 1

Messages

Total messages: 10 (5 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-05-11 21:23:37 UTC) #2
pfeldman
lgtm
4 years, 7 months ago (2016-05-11 23:04:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969913002/40001
4 years, 7 months ago (2016-05-11 23:28:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 02:34:36 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 02:36:06 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/289ae075201b056bed74bd4dbeebe290c4494450
Cr-Commit-Position: refs/heads/master@{#393156}

Powered by Google App Engine
This is Rietveld 408576698