Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1975353002: Revert of Retract GrRenderTarget from AlphaClipMask code (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Retract GrRenderTarget from AlphaClipMask code (patchset #3 id:40001 of https://codereview.chromium.org/1977793004/ ) Reason for revert: Possible cause of leak in ASAN bot: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3351 Original issue's description: > Retract GrRenderTarget from AlphaClipMask code > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1977793004 > > Committed: https://skia.googlesource.com/skia/+/93bc24e8b09b5ad7498ce9bc9a6519c7a43dbc9d TBR=robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/2c0aacbfa403dae16c9e4ccad5dcbaa258481663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -56 lines) Patch
M src/gpu/GrClipMaskManager.h View 1 chunk +12 lines, -12 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 10 chunks +62 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Retract GrRenderTarget from AlphaClipMask code
4 years, 7 months ago (2016-05-13 20:46:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975353002/1
4 years, 7 months ago (2016-05-13 20:47:00 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 20:47:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2c0aacbfa403dae16c9e4ccad5dcbaa258481663

Powered by Google App Engine
This is Rietveld 408576698