Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 197533013: CompositingReasonFinder should use a virtual function instead of a nest of branches (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink, esprehn, ojan, Ian Vollick
Visibility:
Public.

Description

CompositingReasonFinder should use a virtual function instead of a nest of branches This CL begins to move CompositingReasonFinder to using a virtual function on RenderObject instead of a nest of "if video, if canvas" branches. This CL only creates two overrides, one for video and one for canvas. A future CL will create overrides for plugins and iframes, but there's some cleanup work we need to do first. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169685

Patch Set 1 #

Patch Set 2 : Add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -91 lines) Patch
M Source/core/page/ChromeClient.h View 2 chunks +2 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderHTMLCanvas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderHTMLCanvas.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.h View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 11 chunks +14 lines, -45 lines 0 comments Download
A + Source/core/rendering/compositing/CompositingTriggers.h View 1 2 chunks +16 lines, -19 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-20 16:41:30 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-03-20 17:52:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/197533013/1
6 years, 9 months ago (2014-03-20 17:52:57 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 18:01:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-20 18:01:38 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-20 18:38:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/197533013/20001
6 years, 9 months ago (2014-03-20 18:38:50 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 19:56:47 UTC) #8
Message was sent while issue was closed.
Change committed as 169685

Powered by Google App Engine
This is Rietveld 408576698