Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: Source/core/page/ChromeClient.h

Issue 197533013: CompositingReasonFinder should use a virtual function instead of a nest of branches (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add missing file Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/rendering/RenderHTMLCanvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/ChromeClient.h
diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h
index 5414cd5099c1823d93a6e4007b8693ea99edce86..44b5e9eaad07a78dddfa737a1c9c5ac614a5118a 100644
--- a/Source/core/page/ChromeClient.h
+++ b/Source/core/page/ChromeClient.h
@@ -29,6 +29,7 @@
#include "core/frame/ConsoleTypes.h"
#include "core/page/FocusType.h"
#include "core/rendering/RenderEmbeddedObject.h"
+#include "core/rendering/compositing/CompositingTriggers.h"
#include "core/rendering/style/RenderStyleConstants.h"
#include "platform/Cursor.h"
#include "platform/HostWindow.h"
@@ -192,20 +193,8 @@ public:
// Pass 0 as the GraphicsLayer to detatch the root layer.
virtual void attachRootGraphicsLayer(GraphicsLayer*) = 0;
- enum CompositingTrigger {
- ThreeDTransformTrigger = 1 << 0,
- VideoTrigger = 1 << 1,
- PluginTrigger = 1 << 2,
- CanvasTrigger = 1 << 3,
- AnimationTrigger = 1 << 4,
- FilterTrigger = 1 << 5,
- ScrollableInnerFrameTrigger = 1 << 6,
- AllTriggers = 0xFFFFFFFF
- };
- typedef unsigned CompositingTriggerFlags;
-
// Returns a bitfield indicating conditions that can trigger the compositor.
- virtual CompositingTriggerFlags allowedCompositingTriggers() const { return static_cast<CompositingTriggerFlags>(AllTriggers); }
+ virtual CompositingTriggerFlags allowedCompositingTriggers() const { return static_cast<CompositingTriggerFlags>(AllCompositingTriggers); }
virtual void enterFullScreenForElement(Element*) { }
virtual void exitFullScreenForElement(Element*) { }
« no previous file with comments | « no previous file | Source/core/rendering/RenderHTMLCanvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698