Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1975253002: ApplicationConnection devolution, part 2.1. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work792-x-work791_service_registry_spimpl
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 2.1. A.k.a. nuke InterfaceFactory, part 1. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/66402b5d58a150b022382d8de8ba898ad115ddb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -193 lines) Patch
M examples/apptest/example_service_application.h View 2 chunks +1 line, -7 lines 0 comments Download
M examples/apptest/example_service_application.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M examples/bank_app/bank.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M examples/echo/README.md View 1 chunk +9 lines, -10 lines 0 comments Download
M examples/echo/echo_server.cc View 4 chunks +24 lines, -34 lines 0 comments Download
M examples/echo_terminal/main.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M examples/hello_mojo/hello_mojo_server.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M examples/indirect_service/indirect_integer_service.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M examples/indirect_service/integer_service.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M examples/native_run_app/native_run_app.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M mojo/ui/content_viewer_app.h View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/ui/content_viewer_app.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M mojo/ui/view_provider_app.h View 2 chunks +1 line, -6 lines 0 comments Download
M mojo/ui/view_provider_app.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M services/asset_bundle/main.cc View 2 chunks +19 lines, -23 lines 0 comments Download

Depends on Patchset:

Issue 1977043002 Patch 1

Messages

Total messages: 5 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1977043002/.
4 years, 7 months ago (2016-05-13 18:01:31 UTC) #1
vardhan
lgtm once interface_factory.h & application_connection.h is removed, probably worth sending an email to mojo-dev@?
4 years, 7 months ago (2016-05-13 18:17:36 UTC) #2
viettrungluu
Thanks. On 2016/05/13 18:17:36, vardhan wrote: > lgtm > > once interface_factory.h & application_connection.h is ...
4 years, 7 months ago (2016-05-13 18:18:43 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-13 18:20:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
66402b5d58a150b022382d8de8ba898ad115ddb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698