Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1975143002: allow Skia to be the default graphics engine (Closed)

Created:
4 years, 7 months ago by caryclark
Modified:
4 years, 7 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

allow Skia to be the default graphics engine PDFium uses fxge to denote the graphics engine used for general rendering. When pdf_use_skia=1 is set, use Skia as the default engine instead of antigrain. R=tsepez@chromium.org,dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d6e18875ce024a341e221db689cedf10d433be8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -76 lines) Patch
M core/fxge/agg/fx_agg_driver.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 chunk +4 lines, -24 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +20 lines, -20 lines 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 5 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975143002/1
4 years, 7 months ago (2016-05-13 12:11:30 UTC) #2
caryclark
4 years, 7 months ago (2016-05-13 12:11:52 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 12:28:21 UTC) #5
caryclark
4 years, 7 months ago (2016-05-13 12:49:22 UTC) #8
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-13 17:54:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975143002/1
4 years, 7 months ago (2016-05-13 17:57:04 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 17:57:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d6e18875ce024a341e221db689cedf10d433...

Powered by Google App Engine
This is Rietveld 408576698