fpdfsdk/fpdf_progressive.cpp - Issue 1975143002: allow Skia to be the default graphics engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdf_progressive.cpp

Issue 1975143002: allow Skia to be the default graphics engine (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdf_progressive.cpp

diff --git a/fpdfsdk/fpdf_progressive.cpp b/fpdfsdk/fpdf_progressive.cpp

index 1450f8e74b2b3d2818f014b82bfd9da23b554bc3..d42d954bb9f0c2c6979a4620b7aeccefea113f44 100644

--- a/fpdfsdk/fpdf_progressive.cpp

+++ b/fpdfsdk/fpdf_progressive.cpp

@@ -41,21 +41,12 @@ DLLEXPORT int STDCALL FPDF_RenderPageBitmap_Start(FPDF_BITMAP bitmap,

CRenderContext* pContext = new CRenderContext;

pPage->SetPrivateData((void*)1, pContext, DropContext);

-#ifdef _SKIA_SUPPORT_

- pContext->m_pDevice = new CFX_SkiaDevice;

- if (flags & FPDF_REVERSE_BYTE_ORDER)

- ((CFX_SkiaDevice*)pContext->m_pDevice)

- ->Attach((CFX_DIBitmap*)bitmap, 0, TRUE);

- else

- ((CFX_SkiaDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap);

-#else

pContext->m_pDevice = new CFX_FxgeDevice;

if (flags & FPDF_REVERSE_BYTE_ORDER)

((CFX_FxgeDevice*)pContext->m_pDevice)

->Attach((CFX_DIBitmap*)bitmap, 0, TRUE);

else

((CFX_FxgeDevice*)pContext->m_pDevice)->Attach((CFX_DIBitmap*)bitmap);

-#endif

IFSDK_PAUSE_Adapter IPauseAdapter(pause);

FPDF_RenderPage_Retail(pContext, page, start_x, start_y, size_x, size_y,

« no previous file with comments | « core/fxge/skia/fx_skia_device.cpp ('k') | fpdfsdk/fpdfformfill.cpp » ('j') | no next file with comments »