Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1974883002: Remove compiler warning when building. (Closed)

Created:
4 years, 7 months ago by Karl
Modified:
4 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove compiler warning when building. Clang doesn't realize that the end of method NaClBitsreamCursor::readArrayAbbreviationField is unreachable. Add unreachable call to make the compiler happy. BUG=None R=stichnot@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/83991f993fea6cd9c515df12c3270ab9c0746215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
This patch matches the change in CL https://codereview.chromium.org/1963193003
4 years, 7 months ago (2016-05-12 17:11:39 UTC) #3
Jim Stichnoth
lgtm
4 years, 7 months ago (2016-05-12 17:18:10 UTC) #4
Karl
4 years, 7 months ago (2016-05-12 17:24:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83991f993fea6cd9c515df12c3270ab9c0746215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698