Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1963193003: Remove compiler warning when building within LLVM trunk. (Closed)

Created:
4 years, 7 months ago by Karl
Modified:
4 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove compiler warning when building within LLVM trunk. Clang doesn't realize that the end of method NaClBitstreamCursor::readArrayAbbreviatedField is unreachable. Add unreachable call to make the compiler happy. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1040d86c3c653916dafcac35183482ecfc60a308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pnacl-llvm/NaClBitstreamReader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 7 months ago (2016-05-10 19:44:18 UTC) #3
Jim Stichnoth
LGTM. Could you also make the same change to the original version of that file? ...
4 years, 7 months ago (2016-05-10 20:48:52 UTC) #4
Karl
Committed patchset #1 (id:1) manually as 1040d86c3c653916dafcac35183482ecfc60a308 (presubmit successful).
4 years, 7 months ago (2016-05-12 17:12:27 UTC) #6
Karl
4 years, 7 months ago (2016-05-12 17:13:50 UTC) #7
Message was sent while issue was closed.
Created CL https://codereview.chromium.org/1974883002 to put into NaCl
repository.

Powered by Google App Engine
This is Rietveld 408576698