Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: src/deoptimizer.h

Issue 19748003: Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize constants (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/deoptimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.h
===================================================================
--- src/deoptimizer.h (revision 15739)
+++ src/deoptimizer.h (working copy)
@@ -510,6 +510,22 @@
*GetFrameSlotPointer(offset) = value;
}
+ void SetCallerPc(unsigned offset, intptr_t value) {
danno 2013/07/18 10:51:24 A difference copy of this routine should be in the
haitao.feng 2013/07/18 12:18:20 Done.
+ if (kPCOnStackSize != kPointerSize) {
+ ASSERT(kPCOnStackSize == kPointerSize + kPointerSize);
+ SetFrameSlot(offset + kPointerSize, 0);
danno 2013/07/18 10:51:24 This assumes little endianess, I would much prefer
haitao.feng 2013/07/18 12:18:20 Done.
+ }
+ SetFrameSlot(offset, value);
+ }
+
+ void SetCallerFp(unsigned offset, intptr_t value) {
danno 2013/07/18 10:51:24 Same as above, there should be a different impleme
haitao.feng 2013/07/18 12:18:20 Done.
+ if (kFPOnStackSize != kPointerSize) {
+ ASSERT(kFPOnStackSize == kPointerSize + kPointerSize);
+ SetFrameSlot(offset + kPointerSize, 0);
+ }
+ SetFrameSlot(offset, value);
+ }
+
intptr_t GetRegister(unsigned n) const {
ASSERT(n < ARRAY_SIZE(registers_));
return registers_[n];
« no previous file with comments | « no previous file | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698