Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4732)

Unified Diff: chrome/android/java/res/layout/feedback_reporting_view.xml

Issue 197473006: Add FeedbackReporter for reporting distillation quality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated implementation with UI Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/feedback_reporting_view.xml
diff --git a/chrome/android/java/res/layout/feedback_reporting_view.xml b/chrome/android/java/res/layout/feedback_reporting_view.xml
new file mode 100644
index 0000000000000000000000000000000000000000..96b4446b34217dff246610be53cf6944a4e0fc5c
--- /dev/null
+++ b/chrome/android/java/res/layout/feedback_reporting_view.xml
@@ -0,0 +1,88 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2014 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+
+<org.chromium.chrome.browser.dom_distiller.FeedbackReportingView
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:id="@+id/feedback_reporting_view"
newt (away) 2014/03/17 18:19:19 nit, put id before all other android: attributes
nyquist 2014/03/17 20:13:42 Done.
+ android:background="#656565">
+
+ <LinearLayout
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
newt (away) 2014/03/17 18:19:19 wrap_content
nyquist 2014/03/17 20:13:42 Done.
+ android:orientation="vertical">
+
+ <LinearLayout
+ android:baselineAligned="false"
+ android:layout_width="match_parent"
+ android:layout_height="15dp"
+ android:orientation="horizontal">
+
+ <View
+ android:background="#4285F4"
+ android:layout_height="match_parent"
+ android:layout_width="match_parent"
newt (away) 2014/03/17 18:19:19 layout_width="0dp" for all four of these views
nyquist 2014/03/17 20:13:42 Done.
+ android:layout_weight="1" />
+
+ <View
+ android:background="#DB4437"
+ android:layout_height="match_parent"
+ android:layout_width="match_parent"
+ android:layout_weight="1" />
+
+ <View
+ android:background="#F4B400"
+ android:layout_height="match_parent"
+ android:layout_width="match_parent"
+ android:layout_weight="1" />
+
+ <View
+ android:background="#0F9D58"
+ android:layout_height="match_parent"
+ android:layout_width="match_parent"
+ android:layout_weight="1" />
+ </LinearLayout>
+
+ <LinearLayout
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
newt (away) 2014/03/17 18:19:19 wrap_content
nyquist 2014/03/17 20:13:42 Done.
+ android:layout_margin="10dp"
+ android:orientation="horizontal">
+
+ <ImageButton
+ android:id="@+id/distillation_quality_answer_no"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:contentDescription="@string/distillation_quality_answer_no"
+ android:background="@null"
+ android:src="@drawable/distillation_quality_answer_no" />
+
+ <TextView
+ android:id="@+id/distillation_quality_question"
+ android:layout_width="0dp"
+ android:layout_height="wrap_content"
+ android:layout_weight="1"
+ android:gravity="center"
+ android:padding="10dp"
+ android:text="@string/distillation_quality_question"
+ android:textSize="20sp"
+ android:textColor="@android:color/white"
+ android:textStyle="bold"
+ android:fontFamily="sans-serif" />
+
+ <ImageButton
+ android:id="@+id/distillation_quality_answer_yes"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:contentDescription="@string/distillation_quality_answer_yes"
+ android:background="@null"
+ android:src="@drawable/distillation_quality_answer_yes" />
+
+ </LinearLayout>
+ </LinearLayout>
+
+</org.chromium.chrome.browser.dom_distiller.FeedbackReportingView>

Powered by Google App Engine
This is Rietveld 408576698