chrome/android/java/res/layout/feedback_reporting_view.xml - Issue 197473006: Add FeedbackReporter for reporting distillation quality.

Side by Side Diff: chrome/android/java/res/layout/feedback_reporting_view.xml

Issue 197473006: Add FeedbackReporter for reporting distillation quality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated implementation with UI Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/android/java/res/drawable/distillation_quality_answer_yes.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/FeedbackReporter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6

	7 <org.chromium.chrome.browser.dom_distiller.FeedbackReportingView

	8 xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:id="@+id/feedback_reporting_view"
	newt (away) 2014/03/17 18:19:19 nit, put id before all other android: attributes nit, put id before all other android: attributes nyquist 2014/03/17 20:13:42 Done. Show quoted text On 2014/03/17 18:19:19, newt wrote: > nit, put id before all other android: attributes Done.
	12 android:background="#656565">

	13

	14 <LinearLayout

	15 android:layout_width="match_parent"

	16 android:layout_height="match_parent"
	newt (away) 2014/03/17 18:19:19 wrap_content wrap_content nyquist 2014/03/17 20:13:42 Done. Show quoted text On 2014/03/17 18:19:19, newt wrote: > wrap_content Done.
	17 android:orientation="vertical">

	18

	19 <LinearLayout

	20 android:baselineAligned="false"

	21 android:layout_width="match_parent"

	22 android:layout_height="15dp"

	23 android:orientation="horizontal">

	24

	25 <View

	26 android:background="#4285F4"

	27 android:layout_height="match_parent"

	28 android:layout_width="match_parent"
	newt (away) 2014/03/17 18:19:19 layout_width="0dp" for all four of these views layout_width="0dp" for all four of these views nyquist 2014/03/17 20:13:42 Done. Show quoted text On 2014/03/17 18:19:19, newt wrote: > layout_width="0dp" for all four of these views Done.
	29 android:layout_weight="1" />

	30

	31 <View

	32 android:background="#DB4437"

	33 android:layout_height="match_parent"

	34 android:layout_width="match_parent"

	35 android:layout_weight="1" />

	36

	37 <View

	38 android:background="#F4B400"

	39 android:layout_height="match_parent"

	40 android:layout_width="match_parent"

	41 android:layout_weight="1" />

	42

	43 <View

	44 android:background="#0F9D58"

	45 android:layout_height="match_parent"

	46 android:layout_width="match_parent"

	47 android:layout_weight="1" />

	48 </LinearLayout>

	49

	50 <LinearLayout

	51 android:layout_width="match_parent"

	52 android:layout_height="match_parent"
	newt (away) 2014/03/17 18:19:19 wrap_content wrap_content nyquist 2014/03/17 20:13:42 Done. Show quoted text On 2014/03/17 18:19:19, newt wrote: > wrap_content Done.
	53 android:layout_margin="10dp"

	54 android:orientation="horizontal">

	55

	56 <ImageButton

	57 android:id="@+id/distillation_quality_answer_no"

	58 android:layout_width="wrap_content"

	59 android:layout_height="wrap_content"

	60 android:contentDescription="@string/distillation_quality_answer_ no"

	61 android:background="@null"

	62 android:src="@drawable/distillation_quality_answer_no" />

	63

	64 <TextView

	65 android:id="@+id/distillation_quality_question"

	66 android:layout_width="0dp"

	67 android:layout_height="wrap_content"

	68 android:layout_weight="1"

	69 android:gravity="center"

	70 android:padding="10dp"

	71 android:text="@string/distillation_quality_question"

	72 android:textSize="20sp"

	73 android:textColor="@android:color/white"

	74 android:textStyle="bold"

	75 android:fontFamily="sans-serif" />

	76

	77 <ImageButton

	78 android:id="@+id/distillation_quality_answer_yes"

	79 android:layout_width="wrap_content"

	80 android:layout_height="wrap_content"

	81 android:contentDescription="@string/distillation_quality_answer_ yes"

	82 android:background="@null"

	83 android:src="@drawable/distillation_quality_answer_yes" />

	84

	85 </LinearLayout>

	86 </LinearLayout>

	87

	88 </org.chromium.chrome.browser.dom_distiller.FeedbackReportingView>

OLD	NEW