third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h - Issue 1974713003: Speed up fix for expando-loss conformance test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

Issue 1974713003: Speed up fix for expando-loss conformance test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add V8CopyablePersistent alias to avoid incorrect usage. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/WebGLObject.h ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

index 7a1d1ac7f9255701e718854e904680eeb6cb82d6..f2abff9bf9d699fb22651c0fc73c9b8d514503b3 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

@@ -34,6 +34,8 @@ public:

void setArrayBufferForAttrib(GLuint, WebGLBuffer*);

void unbindBuffer(WebGLBuffer*);

+ V8CopyablePersistent<v8::Array>* getPersistentCache();

DECLARE_VIRTUAL_TRACE();

protected:

@@ -51,6 +53,10 @@ private:

bool m_destructionInProgress;

Member<WebGLBuffer> m_boundElementArrayBuffer;

HeapVector<Member<WebGLBuffer>> m_arrayBufferList;

+ // For preserving the wrappers of WebGLBuffer objects latched in

+ // via vertexAttribPointer calls.

+ V8CopyablePersistent<v8::Array> m_arrayBufferWrappers;

};

} // namespace blink