third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h - Issue 1974713003: Speed up fix for expando-loss conformance test.

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

Issue 1974713003: Speed up fix for expando-loss conformance test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add V8CopyablePersistent alias to avoid incorrect usage. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/webgl/WebGLObject.h ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WebGLVertexArrayObjectBase_h	5 #ifndef WebGLVertexArrayObjectBase_h

6 #define WebGLVertexArrayObjectBase_h	6 #define WebGLVertexArrayObjectBase_h

7	7

8 #include "modules/webgl/WebGLBuffer.h"	8 #include "modules/webgl/WebGLBuffer.h"

9 #include "modules/webgl/WebGLContextObject.h"	9 #include "modules/webgl/WebGLContextObject.h"

10 #include "platform/heap/Handle.h"	10 #include "platform/heap/Handle.h"

(...skipping 16 matching lines...) Expand all Loading...
27 bool hasEverBeenBound() const { return object() && m_hasEverBeenBound; }	27 bool hasEverBeenBound() const { return object() && m_hasEverBeenBound; }

28 void setHasEverBeenBound() { m_hasEverBeenBound = true; }	28 void setHasEverBeenBound() { m_hasEverBeenBound = true; }

29	29

30 WebGLBuffer* boundElementArrayBuffer() const { return m_boundElementArrayBuf fer; }	30 WebGLBuffer* boundElementArrayBuffer() const { return m_boundElementArrayBuf fer; }

31 void setElementArrayBuffer(WebGLBuffer*);	31 void setElementArrayBuffer(WebGLBuffer*);

32	32

33 WebGLBuffer* getArrayBufferForAttrib(size_t);	33 WebGLBuffer* getArrayBufferForAttrib(size_t);

34 void setArrayBufferForAttrib(GLuint, WebGLBuffer*);	34 void setArrayBufferForAttrib(GLuint, WebGLBuffer*);

35 void unbindBuffer(WebGLBuffer*);	35 void unbindBuffer(WebGLBuffer*);

36	36

	37 V8CopyablePersistent<v8::Array>* getPersistentCache();

	38

37 DECLARE_VIRTUAL_TRACE();	39 DECLARE_VIRTUAL_TRACE();

38	40

39 protected:	41 protected:

40 WebGLVertexArrayObjectBase(WebGLRenderingContextBase*, VaoType);	42 WebGLVertexArrayObjectBase(WebGLRenderingContextBase*, VaoType);

41	43

42 private:	44 private:

43 void dispatchDetached(gpu::gles2::GLES2Interface*);	45 void dispatchDetached(gpu::gles2::GLES2Interface*);

44 bool hasObject() const override { return m_object != 0; }	46 bool hasObject() const override { return m_object != 0; }

45 void deleteObjectImpl(gpu::gles2::GLES2Interface*) override;	47 void deleteObjectImpl(gpu::gles2::GLES2Interface*) override;

46	48

47 GLuint m_object;	49 GLuint m_object;

48	50

49 VaoType m_type;	51 VaoType m_type;

50 bool m_hasEverBeenBound;	52 bool m_hasEverBeenBound;

51 bool m_destructionInProgress;	53 bool m_destructionInProgress;

52 Member<WebGLBuffer> m_boundElementArrayBuffer;	54 Member<WebGLBuffer> m_boundElementArrayBuffer;

53 HeapVector<Member<WebGLBuffer>> m_arrayBufferList;	55 HeapVector<Member<WebGLBuffer>> m_arrayBufferList;

	56

	57 // For preserving the wrappers of WebGLBuffer objects latched in

	58 // via vertexAttribPointer calls.

	59 V8CopyablePersistent<v8::Array> m_arrayBufferWrappers;

54 };	60 };

55	61

56 } // namespace blink	62 } // namespace blink

57	63

58 #endif // WebGLVertexArrayObjectBase_h	64 #endif // WebGLVertexArrayObjectBase_h

OLD	NEW