Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5440)

Unified Diff: chrome/test/data/webui/md_history/history_list_test.js

Issue 1974713002: [MD History] Unify query state in history-app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@secondary_toolbar
Patch Set: closure Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_history/history_list_test.js
diff --git a/chrome/test/data/webui/md_history/history_list_test.js b/chrome/test/data/webui/md_history/history_list_test.js
index 876dc54bf1f7a2de6012b54669f0d58e941fc36e..05b3cbffbe733c7f9f3c360818c4189486dce612 100644
--- a/chrome/test/data/webui/md_history/history_list_test.js
+++ b/chrome/test/data/webui/md_history/history_list_test.js
@@ -30,7 +30,7 @@ cr.define('md_history.history_list_test', function() {
});
test('cancelling selection of multiple items', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
flush(function() {
var items = Polymer.dom(element.root)
.querySelectorAll('history-item');
@@ -62,7 +62,7 @@ cr.define('md_history.history_list_test', function() {
});
test('setting first and last items', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
flush(function() {
var items =
@@ -80,8 +80,8 @@ cr.define('md_history.history_list_test', function() {
});
test('updating history results', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
- element.addNewResults(ADDITIONAL_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
+ element.addNewResults(ADDITIONAL_RESULTS);
flush(function() {
var items =
@@ -100,13 +100,12 @@ cr.define('md_history.history_list_test', function() {
});
test('removeVisits for multiple items', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
// Ensure that the correct identifying data is being used for removal.
registerMessageCallback('removeVisits', this, function (toBeRemoved) {
assertEquals(toBeRemoved[0].url, element.historyData[0].url);
assertEquals(toBeRemoved[1].url, element.historyData[1].url);
- console.log(element.historyData[0].timestamps);
tsergeant 2016/05/13 03:41:06 lol
calamity 2016/05/18 01:41:52 Acklolaged.
assertEquals(toBeRemoved[0].timestamps,
element.historyData[0].allTimestamps);
assertEquals(toBeRemoved[1].timestamps,
@@ -126,8 +125,8 @@ cr.define('md_history.history_list_test', function() {
});
test('deleting multiple items from view', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
- element.addNewResults(ADDITIONAL_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
+ element.addNewResults(ADDITIONAL_RESULTS);
flush(function() {
items = Polymer.dom(element.root).querySelectorAll('history-item');
@@ -165,8 +164,8 @@ cr.define('md_history.history_list_test', function() {
test('search results display with correct item title', function(done) {
element.addNewResults(
- [createHistoryEntry('2016-03-15', 'https://www.google.com')],
- 'Google');
+ [createHistoryEntry('2016-03-15', 'https://www.google.com')]);
+ element.searchedTerm = 'Google';
flush(function() {
var item = element.$$('history-item');
@@ -185,13 +184,13 @@ cr.define('md_history.history_list_test', function() {
});
test('correct display message when no history available', function(done) {
- element.addNewResults([], '');
+ element.addNewResults([]);
flush(function() {
assertFalse(element.$['no-results'].hidden);
assertTrue(element.$['infinite-list'].hidden);
- element.addNewResults(TEST_HISTORY_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
flush(function() {
assertTrue(element.$['no-results'].hidden);
@@ -203,6 +202,7 @@ cr.define('md_history.history_list_test', function() {
teardown(function() {
element.historyData = [];
+ element.searchedTerm = '';
registerMessageCallback('removeVisits', this, undefined);
});
});

Powered by Google App Engine
This is Rietveld 408576698