[MD History] Unify query state in history-app.

chrome/test/data/webui/md_history/history_item_test.js

Index: chrome/test/data/webui/md_history/history_item_test.js
diff --git a/chrome/test/data/webui/md_history/history_item_test.js b/chrome/test/data/webui/md_history/history_item_test.js
index c65e8d6fa4e13df1241921da2d73517a3a4aae9b..ec011c8614c25b30288bccdc06bfe86e485dbcf7 100644
--- a/chrome/test/data/webui/md_history/history_item_test.js
+++ b/chrome/test/data/webui/md_history/history_item_test.js
@@ -28,7 +28,7 @@ cr.define('md_history.history_item_test', function() {
       });
 
       test('basic separator insertion', function(done) {
-        element.addNewResults(TEST_HISTORY_RESULTS, '');
+        element.addNewResults(TEST_HISTORY_RESULTS);
         flush(function() {
           // Check that the correct number of time gaps are inserted.
           var items =
@@ -46,7 +46,8 @@ cr.define('md_history.history_item_test', function() {
       });
 
       test('separator insertion for search', function(done) {
-        element.addNewResults(SEARCH_HISTORY_RESULTS, 'search');
+        element.addNewResults(SEARCH_HISTORY_RESULTS);
+        element.searchedTerm = 'search';

[tsergeant, 2016/05/13 03:41:06]

Related to previous question, is searchedTerm expected to be set before
addNewResults?

searchedTerm is necessary for needsTimeGap_, which is computed when the
iron-list updates...and it's unclear whether that is done immediately or
deferred.

Even if the way you've written it here is correct, there's the possibility for
this test to give a false positive (It would be pass even if searchTerm == ''),
so we should probably fix that.

[calamity, 2016/05/18 01:41:52]

Fixed this test.

         flush(function() {
           var items =
               Polymer.dom(element.root).querySelectorAll('history-item');
@@ -60,7 +61,7 @@ cr.define('md_history.history_item_test', function() {
       });
 
       test('separator insertion after deletion', function(done) {
-        element.addNewResults(TEST_HISTORY_RESULTS, '');
+        element.addNewResults(TEST_HISTORY_RESULTS);
         flush(function() {
           var items =
               Polymer.dom(element.root).querySelectorAll('history-item');
@@ -86,6 +87,7 @@ cr.define('md_history.history_item_test', function() {
 
       teardown(function() {
         element.historyData = [];
+        element.searchedTerm = '';
       });
     });
   }