Make the launch params the default client behavior for UMA 3g

components/metrics/data_use_tracker.cc

Index: components/metrics/data_use_tracker.cc
diff --git a/components/metrics/data_use_tracker.cc b/components/metrics/data_use_tracker.cc
index 6e3f9b3eb8afd6b77022a3094d01de6216951e6b..a5d8e3f4df3b241267133309528988e8f2a05aea 100644
--- a/components/metrics/data_use_tracker.cc
+++ b/components/metrics/data_use_tracker.cc
@@ -16,6 +16,11 @@ namespace metrics {
 
 namespace {
 
+// Default weekly quota and allowed UMA ratio for UMA log uploads. Can be
+// overridden by variation params.
+const int kDefaultUMAWeeklyQuotaBytes = 204800;
+const double kDefaultUMARatio = 0.05;

[Alexei Svitkine (slow), 2016/05/13 20:46:47]

Are these defaults safe for non-Android platforms? I noticed you stopped
returning false from either of the functions below.

[gayane -on leave until 09-2017, 2016/05/13 20:57:12]

It is not obvious. The functions will be called only if data_use_tracker was
initialized and it will not be initialized for non-Android. I can add explicit
ifdefs in those functions as well. What do you think ?

[Alexei Svitkine (slow), 2016/05/13 20:59:43]

Just having a comment explaining this above these two defaults should be good
fine, but I'm ok with ifdefs too.

[gayane -on leave until 09-2017, 2016/05/16 15:33:04]

Done.

+
 // This function is for forwarding metrics usage pref changes to the appropriate
 // callback on the appropriate thread.
 // TODO(gayane): Reduce the frequency of posting tasks from IO to UI thread.
@@ -173,9 +178,9 @@ bool DataUseTracker::GetUmaWeeklyQuota(int* uma_weekly_quota_bytes) const {
   std::string param_value_str = variations::GetVariationParamValue(
       "UMA_EnableCellularLogUpload", "Uma_Quota");
   if (param_value_str.empty())
-    return false;
-
-  base::StringToInt(param_value_str, uma_weekly_quota_bytes);
+    *uma_weekly_quota_bytes = kDefaultUMAWeeklyQuotaBytes;
+  else
+    base::StringToInt(param_value_str, uma_weekly_quota_bytes);
   return true;
 }
 
@@ -185,8 +190,9 @@ bool DataUseTracker::GetUmaRatio(double* ratio) const {
   std::string param_value_str = variations::GetVariationParamValue(
       "UMA_EnableCellularLogUpload", "Uma_Ratio");
   if (param_value_str.empty())
-    return false;
-  base::StringToDouble(param_value_str, ratio);
+    *ratio = kDefaultUMARatio;
+  else
+    base::StringToDouble(param_value_str, ratio);
   return true;
 }