Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: components/metrics/metrics_service.cc

Issue 1974593002: Make the launch params the default client behavior for UMA 3g (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index 7e31ddb93156bf301ef333bd5cbe71bb7acc9691..071c96897103c1db2a9f4690cb6d6f6f616336c1 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -232,21 +232,6 @@ void MarkAppCleanShutdownAndCommit(CleanExitBeacon* clean_exit_beacon,
}
#endif // defined(OS_ANDROID) || defined(OS_IOS)
-// Determines if current log should be sent based on sampling rate. Returns true
-// if the sampling rate is not set.
-bool ShouldUploadLog() {
- std::string probability_str = variations::GetVariationParamValue(
- "UMA_EnableCellularLogUpload", "Sample_Probability");
- if (probability_str.empty())
- return true;
-
- int probability;
- // In case specified sampling rate is invalid.
- if (!base::StringToInt(probability_str, &probability))
- return true;
- return base::RandInt(1, 100) <= probability;
-}
-
} // namespace
// static
@@ -983,11 +968,6 @@ void MetricsService::SendStagedLog() {
DCHECK(!log_upload_in_progress_);
log_upload_in_progress_ = true;
- if (!ShouldUploadLog()) {
- SkipAndDiscardUpload();
- return;
- }
-
if (!log_uploader_) {
log_uploader_ = client_->CreateUploader(
base::Bind(&MetricsService::OnLogUploadComplete,

Powered by Google App Engine
This is Rietveld 408576698