Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1974463002:
Harden linear gradients (Closed)
DescriptionHarden linear gradients
Ensure that the last offset == 1.0f when implict positions are used
(previously subject to float imprecision).
BUG=skia:5288, chromium:598484
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974463002
Committed: https://skia.googlesource.com/skia/+/748d620adce9e4855ac0b4b565a6659b803baaa4
Patch Set 1 #Patch Set 2 : win build fix #Patch Set 3 : remove unneeded 1-color veto #
Messages
Total messages: 23 (10 generated)
Description was changed from ========== Harden linear gradients 1) ensure that we only process gradients with >= 2 color stops (this is already documented for all gradients except 2p conical) 2) ensure that the last offset == 1.0f when implict positions are used (previously subject to float imprecision) BUG=skia:5288,chromium:598484 R=reed@google.com ========== to ========== Harden linear gradients 1) ensure that we only process gradients with >= 2 color stops (this is already documented for all gradients except 2p conical) 2) ensure that the last offset == 1.0f when implict positions are used (previously subject to float imprecision) BUG=skia:5288,chromium:598484 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974463002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974463002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
not sure why we can't gracefully handle #colors == 1, either by expanding it to 2 (as the old macro does) or by returning a colorshader.
On 2016/05/11 17:25:41, reed1 wrote: > not sure why we can't gracefully handle #colors == 1, either by expanding it to > 2 (as the old macro does) or by returning a colorshader. Huh, I completely missed that logic. That means #1 is not needed, I'll update.
Description was changed from ========== Harden linear gradients 1) ensure that we only process gradients with >= 2 color stops (this is already documented for all gradients except 2p conical) 2) ensure that the last offset == 1.0f when implict positions are used (previously subject to float imprecision) BUG=skia:5288,chromium:598484 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Harden linear gradients Ensure that the last offset == 1.0f when implict positions are used (previously subject to float imprecision). BUG=skia:5288,chromium:598484 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974463002/40001
On 2016/05/11 17:33:37, f(malita) wrote: > On 2016/05/11 17:25:41, reed1 wrote: > > not sure why we can't gracefully handle #colors == 1, either by expanding it > to > > 2 (as the old macro does) or by returning a colorshader. > > Huh, I completely missed that logic. That means #1 is not needed, I'll update. Done, PTAL.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974463002/40001
Message was sent while issue was closed.
Description was changed from ========== Harden linear gradients Ensure that the last offset == 1.0f when implict positions are used (previously subject to float imprecision). BUG=skia:5288,chromium:598484 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Harden linear gradients Ensure that the last offset == 1.0f when implict positions are used (previously subject to float imprecision). BUG=skia:5288,chromium:598484 R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/748d620adce9e4855ac0b4b565a6659b803baaa4 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/748d620adce9e4855ac0b4b565a6659b803baaa4 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
