Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1974353003:
Add blurcircles2 GM (Closed)
|
Created:
4 years, 7 months ago by bsalomon Modified:
4 years, 7 months ago Reviewers:
robertphillips CC:
reviews_skia.org Base URL:
https://chromium.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd blurcircles2 GM
In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison.
In Sample mode this draws a single circle and almost-circle with animating radius and blur radius.
BUG=skia:5224
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1974353003
Committed: https://skia.googlesource.com/skia/+/c67bb575d0393bef8517810c8f7c578804403c61
Patch Set 1 #
Total comments: 8
Patch Set 2 : Address comments #Patch Set 3 : doubletoscalar #Patch Set 4 : more warning fixes #Messages
Total messages: 20 (11 generated)
Description was changed from ========== Add blurcircles2 GM In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison. In Sample mode this draws a single circle and almost-circle with animating radius and blur radius. BUG=skia:5224 ========== to ========== Add blurcircles2 GM In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison. In Sample mode this draws a single circle and almost-circle with animating radius and blur radius. BUG=skia:5224 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
bsalomon@google.com changed reviewers: + robertphillips@google.com
I suspect I'll wind up turning this into a bench, expand the range of radii tested by forking it into multiple GM instances (for image-size reasons), and delete the original circleblurs GM.
lgtm https://codereview.chromium.org/1974353003/diff/1/gm/SkAnimTimer.h File gm/SkAnimTimer.h (right): https://codereview.chromium.org/1974353003/diff/1/gm/SkAnimTimer.h#newcode110 gm/SkAnimTimer.h:110: */ Isn't this more commonly known as ping-pong? https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp File gm/blurcircles2.cpp (right): https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp#newcode16 gm/blurcircles2.cpp:16: // Copy description in from CL description ? https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp#newcode56 gm/blurcircles2.cpp:56: almostCircleMaker(fAnimRadius, &almostCircle); Do we care to make almostCircle volatile ? https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp#newcode70 gm/blurcircles2.cpp:70: SkScalar lineWidth = 0; rm space in "kRadiusSteps -1" - or add another one ?
https://codereview.chromium.org/1974353003/diff/1/gm/SkAnimTimer.h File gm/SkAnimTimer.h (right): https://codereview.chromium.org/1974353003/diff/1/gm/SkAnimTimer.h#newcode110 gm/SkAnimTimer.h:110: */ On 2016/05/13 18:44:16, robertphillips wrote: > Isn't this more commonly known as ping-pong? Done. https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp File gm/blurcircles2.cpp (right): https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp#newcode16 gm/blurcircles2.cpp:16: On 2016/05/13 18:44:16, robertphillips wrote: > // Copy description in from CL description ? Done. https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp#newcode56 gm/blurcircles2.cpp:56: almostCircleMaker(fAnimRadius, &almostCircle); On 2016/05/13 18:44:17, robertphillips wrote: > Do we care to make almostCircle volatile ? Done. https://codereview.chromium.org/1974353003/diff/1/gm/blurcircles2.cpp#newcode70 gm/blurcircles2.cpp:70: SkScalar lineWidth = 0; On 2016/05/13 18:44:17, robertphillips wrote: > rm space in "kRadiusSteps -1" - or add another one ? Done.
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1974353003/#ps20001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974353003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1974353003/#ps40001 (title: "doubletoscalar")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974353003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1974353003/#ps60001 (title: "more warning fixes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974353003/60001
Message was sent while issue was closed.
Description was changed from ========== Add blurcircles2 GM In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison. In Sample mode this draws a single circle and almost-circle with animating radius and blur radius. BUG=skia:5224 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add blurcircles2 GM In GM mode this draws an array of circles with different radii and different blur radii. Below each circle an almost-circle path is drawn with the same blur filter for comparison. In Sample mode this draws a single circle and almost-circle with animating radius and blur radius. BUG=skia:5224 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c67bb575d0393bef8517810c8f7c578804403c61 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/c67bb575d0393bef8517810c8f7c578804403c61 |
