Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5024)

Unified Diff: chrome/browser/resources/settings/settings_dialog.html

Issue 1974193002: MD Settings: fix overflow scrolling for <settings-dialog> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-polish3
Patch Set: nit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_dialog.html
diff --git a/chrome/browser/resources/settings/settings_dialog.html b/chrome/browser/resources/settings/settings_dialog.html
index d923118da9f71454e0513536e4343cbb4784bbdd..e6b927e61c05db69a282488e7c78aaacf460bf26 100644
--- a/chrome/browser/resources/settings/settings_dialog.html
+++ b/chrome/browser/resources/settings/settings_dialog.html
@@ -8,10 +8,11 @@
<template>
<style include="paper-dialog-shared-styles"></style>
<style>
- .body-content {
+ .body-container {
display: flex;
flex-direction: column;
min-height: 120px;
+ overflow-y: auto;
}
.dialog-content {
@@ -26,7 +27,7 @@
padding: 0;
}
- .top-row {
+ .title-container {
align-items: center;
border-bottom: 1px solid rgba(0, 0, 0, 0.14);
display: flex;
@@ -44,7 +45,6 @@
border-radius: 2px;
max-width: 800px;
min-width: 512px;
- overflow: auto;
}
:host ::content .body,
@@ -57,7 +57,7 @@
margin: 12px 0 24px 0;
}
- :host ::content .button-container {
+ :host ::content .buttons {
-webkit-padding-end: 16px;
-webkit-padding-start: 16px;
display: flex;
@@ -65,7 +65,7 @@
margin-bottom: 12px;
}
- :host ::content .button-container .cancel-button {
+ :host ::content .buttons .cancel-button {
-webkit-margin-end: 8px;
color: var(--paper-grey-600);
}
@@ -98,14 +98,16 @@
}
</style>
<div class="dialog-content">
- <div class="top-row">
+ <div class="title-container">
<content select=".title"></content>
<paper-icon-button icon="cr:clear" on-tap="cancel" id="close">
</paper-icon-button>
</div>
- <div class="body-content">
+ <div class="body-container">
<content select=".body"></content>
- <content select=".button-container"></content>
+ </div>
+ <div class="button-container">
+ <content select=".buttons"></content>
</div>
</div>
<div class="footer-container">

Powered by Google App Engine
This is Rietveld 408576698